Skip to content

Fix side breakage where anchors don't work in slugs.#19261

Merged
g-samroberts merged 2 commits intomainfrom
fix_commands
Feb 17, 2026
Merged

Fix side breakage where anchors don't work in slugs.#19261
g-samroberts merged 2 commits intomainfrom
fix_commands

Conversation

@g-samroberts
Copy link
Contributor

Summary

Fix side breakage where anchors don't work in slugs.

Closes #19260

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@g-samroberts g-samroberts requested review from a team as code owners February 17, 2026 16:30
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @g-samroberts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the documentation sidebar where internal anchor links were non-functional. By standardizing the navigation properties for these links, it ensures that users can correctly navigate to specific sections within documentation pages, significantly improving the user experience and accessibility of the documentation.

Highlights

  • Documentation Sidebar Links: Updated numerous entries in the documentation sidebar from using a 'slug' property to a 'link' property, specifically for paths that include anchor identifiers.
  • Anchor Link Functionality: Resolved an issue where anchor links within the documentation sidebar were not functioning correctly due to an incorrect property being used for navigation.
Changelog
  • docs/sidebar.json
    • Replaced 'slug' property with 'link' for entries containing anchor references to ensure correct navigation.
Activity
  • The pull request was created by g-samroberts to fix an issue with broken anchor links in documentation slugs.
  • A pre-merge checklist has been included by the author, indicating steps for validation and documentation updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with non-functional anchor links in the documentation sidebar. The changes in docs/sidebar.json correctly replace the slug property with link for entries pointing to page anchors, and prepend a leading slash to the path to make it a root-relative URL. These modifications are consistent and effectively resolve the described problem, ensuring that sidebar navigation to specific sections of a page works as expected. The fix is well-targeted and appears correct.

@chrstnb
Copy link
Collaborator

chrstnb commented Feb 17, 2026

Build failed: Build process failed with link errors:

16:34:21 [ERROR] ✗ Found 1 invalid link in 1 file.
16:34:21   └─ /docs/cli/authentication - invalid link
16:34:21 [ERROR] [starlight-links-validator-integration] An unhandled error occurred while running the "astro:build:done" hook

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Size Change: -2 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.4 MB -2 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 17, 2026
@g-samroberts
Copy link
Contributor Author

@chrstnb fixed!

@g-samroberts g-samroberts added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit c62601e Feb 17, 2026
27 checks passed
@g-samroberts g-samroberts deleted the fix_commands branch February 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix sidebar.json

3 participants