fix(core): clarify plan mode constraints and exit mechanism#19438
Conversation
Summary of ChangesHello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request clarifies the operational boundaries and exit procedures for the system's 'Plan Mode'. The changes aim to prevent the model from attempting direct code modifications when it should be planning, and to ensure a clear, user-approved transition from planning to implementation. This improves the model's adherence to its operational policies and enhances the user experience by making the workflow more predictable. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +467 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request effectively clarifies the constraints and exit mechanism for the experimental 'Plan Mode'. The changes include updating the system prompt with a new rule to handle requests for direct code modification, enhancing the description of the exit_plan_mode tool to be more explicit about its purpose, and strengthening a test case to improve its reliability. These modifications are well-aligned with the goal of making the model's behavior more predictable and robust when operating in Plan Mode. The changes are clear, targeted, and represent a solid improvement.
3b9f36d to
8bb6b4b
Compare
Fixes #19437 - Added explicit Rule 5 to system prompt to refuse direct code modification in Plan Mode and proactively explain the restriction. - Enhanced exit_plan_mode tool description to emphasize its role as the mandatory approval and exit mechanism, reducing "policy surprise" failures. - Improved test signal in plan_mode.eval.ts with explicit user approval to stabilize model behavior during transitions.
8bb6b4b to
5e93694
Compare
Fixes #19437