Skip to content

fix(patch): cherry-pick 261788c to release/v0.29.1-pr-19453 to patch version v0.29.1 and create version 0.29.2#19491

Merged
skeshive merged 1 commit intorelease/v0.29.1-pr-19453from
hotfix/v0.29.1/0.29.2/stable/cherry-pick-261788c/pr-19453
Feb 19, 2026
Merged

fix(patch): cherry-pick 261788c to release/v0.29.1-pr-19453 to patch version v0.29.1 and create version 0.29.2#19491
skeshive merged 1 commit intorelease/v0.29.1-pr-19453from
hotfix/v0.29.1/0.29.2/stable/cherry-pick-261788c/pr-19453

Conversation

@gemini-cli-robot
Copy link
Collaborator

This PR automatically cherry-picks commit 261788c to patch version v0.29.1 in the stable release to create version 0.29.2.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of remote admin controls by introducing an explicit adminControlsApplicable flag in the API response. This change streamlines the logic for determining when to stop polling for admin settings and how to handle fetch errors, moving away from implicit HTTP status code checks. Additionally, it ensures that remote admin settings are reset when a user's authentication is refreshed, improving state management.

Highlights

  • Introduced adminControlsApplicable Flag: A new optional boolean field, adminControlsApplicable, was added to the FetchAdminControlsResponseSchema to explicitly indicate whether admin controls are relevant for the current context.
  • Refactored Admin Controls Polling and Error Handling: The logic for fetching and polling admin controls was updated to use the adminControlsApplicable flag. Polling now stops if this flag is false, replacing previous logic that relied on HTTP 403 errors for enterprise users.
  • Modified Error Propagation: Network errors during the initial fetch of admin controls now cause an error to be thrown, rather than returning an empty object and retrying via polling, providing clearer error handling.
  • Cleared Remote Admin Settings on Auth Refresh: Remote admin settings are now explicitly cleared by setting them to undefined when the authentication state is refreshed in the AppContainer, ensuring a clean state.
Changelog
  • packages/cli/src/ui/AppContainer.tsx
    • Cleared remote admin settings upon authentication refresh.
  • packages/core/src/code_assist/admin/admin_controls.test.ts
    • Updated test cases to incorporate the new adminControlsApplicable flag and revised error handling for admin controls fetching.
  • packages/core/src/code_assist/admin/admin_controls.ts
    • Removed isGaxiosError utility.
    • Updated cachedSettings check to ensure non-empty settings are used.
    • Refactored admin controls fetching and polling to utilize the adminControlsApplicable flag for stopping polling and error propagation.
  • packages/core/src/code_assist/types.ts
    • Added an optional adminControlsApplicable boolean field to the FetchAdminControlsResponseSchema.
  • packages/core/src/config/config.ts
    • Updated the setRemoteAdminSettings method to allow undefined as a valid input for clearing remote admin settings.
Activity
  • This pull request was automatically generated to cherry-pick commit 261788cf911c5ea1dd67b1e4084c40b11063a185 to patch version v0.29.1 and create version 0.29.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@skeshive skeshive enabled auto-merge (squash) February 19, 2026 00:15
@github-actions
Copy link

Size Change: -79 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.9 MB -79 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@skeshive skeshive disabled auto-merge February 19, 2026 00:24
@skeshive skeshive merged commit 7f9808c into release/v0.29.1-pr-19453 Feb 19, 2026
26 of 27 checks passed
@skeshive skeshive deleted the hotfix/v0.29.1/0.29.2/stable/cherry-pick-261788c/pr-19453 branch February 19, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants