Skip to content

Comments

chore(core): improve encapsulation and remove unused exports#19556

Merged
adamfweidman merged 2 commits intomainfrom
afw/cleanup-core
Feb 19, 2026
Merged

chore(core): improve encapsulation and remove unused exports#19556
adamfweidman merged 2 commits intomainfrom
afw/cleanup-core

Conversation

@adamfweidman
Copy link
Contributor

@adamfweidman adamfweidman commented Feb 19, 2026

Summary

This PR improves encapsulation in packages/core by making internal symbols private and removing unused exports identified by knip.

Details

  • Encapsulation Improvements: Removed export from several internal symbols in src/config, src/ide, src/agents, src/utils, src/services, src/scheduler, and src/telemetry. These symbols are either only used within their respective files or have no external consumers.
  • Dead Code Removal: Deleted the logInvalidChunk function, which was confirmed as unused.
  • Redundancy Fix: Removed a duplicate definition of GOOGLE_ACCOUNTS_FILENAME in storage.ts and replaced it with an import from paths.ts.

Related Issues

Relates to #18199

How to Validate

  1. Run npm run build at the root.
  2. Run npm test -w @google/gemini-cli-core.
  3. Verify that all 4882 core tests pass.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@adamfweidman adamfweidman requested a review from a team as a code owner February 19, 2026 19:59
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 19, 2026

Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 19, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the internal architecture of the @google/gemini-cli-core package by improving encapsulation and eliminating dead code. It refines the module structure by making several internal functions and constants private, ensuring that only intended components are exposed externally. Additionally, it addresses code redundancy and removes unused logging functionality, contributing to a cleaner and more maintainable codebase.

Highlights

  • Encapsulation Improvements: Internal symbols across src/config, src/ide, src/agents, src/utils, src/services, src/scheduler, and src/telemetry were made private by removing their export declarations, as they are only used internally or have no external consumers.
  • Dead Code Removal: The logInvalidChunk function and related imports were deleted from src/telemetry/loggers.ts as it was identified as unused.
  • Redundancy Fix: A duplicate definition of GOOGLE_ACCOUNTS_FILENAME in src/config/storage.ts was removed and replaced with an import from src/utils/paths.ts.
Changelog
  • packages/core/src/agents/a2aUtils.ts
    • Removed export keyword from extractPartText function.
  • packages/core/src/config/storage.ts
    • Removed duplicate GOOGLE_ACCOUNTS_FILENAME constant and imported it from paths.ts.
    • Updated import statement for GEMINI_DIR and homedir to include GOOGLE_ACCOUNTS_FILENAME.
  • packages/core/src/ide/detect-ide.ts
    • Removed export keyword from isJetBrains function.
  • packages/core/src/mcp/oauth-provider.ts
    • Removed export keyword from OAUTH_DISPLAY_MESSAGE_EVENT constant.
  • packages/core/src/scheduler/confirmation.ts
    • Removed export keyword from awaitConfirmation function.
  • packages/core/src/services/chatCompressionService.ts
    • Removed export keywords from DEFAULT_COMPRESSION_TOKEN_THRESHOLD, COMPRESSION_PRESERVE_THRESHOLD, and COMPRESSION_FUNCTION_RESPONSE_TOKEN_BUDGET constants.
  • packages/core/src/telemetry/loggers.ts
    • Removed InvalidChunkEvent from telemetry event types.
    • Removed recordInvalidChunk from metric recording functions.
    • Deleted the logInvalidChunk function.
  • packages/core/src/telemetry/metrics.ts
    • Removed export keyword from getMeter and initializePerformanceMonitoring functions.
  • packages/core/src/telemetry/semantic.ts
    • Removed export keywords from toOTelPart, toOTelRole, toOTelFinishReason functions.
    • Removed export keywords from TextPart, ToolCallRequestPart, ToolCallResponsePart, ReasoningPart, and GenericPart classes.
  • packages/core/src/utils/toolCallContext.ts
    • Removed export keyword from toolCallContext constant.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adamfweidman adamfweidman reopened this Feb 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on improving code encapsulation and removing unused code within the packages/core module. The changes involve making several internal functions, classes, and constants private to their respective modules by removing the export keyword. Additionally, an unused function (logInvalidChunk) and a duplicate constant definition have been removed. These changes are well-executed, correctly identified, and contribute positively to the project's maintainability by reducing the public API surface and cleaning up dead code. The pull request adheres to good software engineering practices.

@github-actions
Copy link

Size Change: -86 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.5 MB -86 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 19, 2026
@adamfweidman adamfweidman added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit a468407 Feb 19, 2026
35 of 53 checks passed
@adamfweidman adamfweidman deleted the afw/cleanup-core branch February 19, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants