chore(core): improve encapsulation and remove unused exports#19556
chore(core): improve encapsulation and remove unused exports#19556adamfweidman merged 2 commits intomainfrom
Conversation
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the internal architecture of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request focuses on improving code encapsulation and removing unused code within the packages/core module. The changes involve making several internal functions, classes, and constants private to their respective modules by removing the export keyword. Additionally, an unused function (logInvalidChunk) and a duplicate constant definition have been removed. These changes are well-executed, correctly identified, and contribute positively to the project's maintainability by reducing the public API surface and cleaning up dead code. The pull request adheres to good software engineering practices.
|
Size Change: -86 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
Summary
This PR improves encapsulation in
packages/coreby making internal symbols private and removing unused exports identified byknip.Details
exportfrom several internal symbols insrc/config,src/ide,src/agents,src/utils,src/services,src/scheduler, andsrc/telemetry. These symbols are either only used within their respective files or have no external consumers.logInvalidChunkfunction, which was confirmed as unused.GOOGLE_ACCOUNTS_FILENAMEinstorage.tsand replaced it with an import frompaths.ts.Related Issues
Relates to #18199
How to Validate
npm run buildat the root.npm test -w @google/gemini-cli-core.Pre-Merge Checklist