Revert "feat(ui): add source indicators to slash commands"#19695
Revert "feat(ui): add source indicators to slash commands"#19695
Conversation
This reverts commit d08b1ef.
|
Hi @ehedlund, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @ehedlund, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous feature that introduced source indicators (namespaces) for slash commands. The revert streamlines the command loading and conflict resolution process by eliminating the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts the previous implementation of slash command source indicators that used a namespace property and colon-separated names. It introduces a new approach where extension command conflicts are resolved by prepending extensionName. to the command name, and the command's description is prefixed with [extensionName] to indicate its source. The changes are consistent across the command service, file loader, and type definitions, and the accompanying test updates correctly reflect the new logic. The new implementation for conflict resolution appears robust. Overall, the changes are well-executed and I don't see any issues.
|
Size Change: -811 B (0%) Total Size: 25.2 MB ℹ️ View Unchanged
|

Reverts #18839