Extension explore dialog UX polish

[yasuo72]

Fixes #19684

• Make extension explore list responsive to available terminal height.
• Improve scrolling so selection stays visible (not forced to the middle).
• Align selection indicator behavior in the registry view.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @yasuo72, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the user experience within the extension explore dialog by introducing dynamic list sizing and more intuitive scrolling. It also improves the clarity and helpfulness of compatibility warnings for users of JetBrains terminals by offering platform-specific recommendations.

Highlights

• Responsive List Sizing: The extension explore list now dynamically adjusts its size based on the available terminal height, rather than a fixed maximum number of items.
• Improved Scrolling Behavior: The scrolling logic has been enhanced to keep the selected item visible, preventing it from being forced to the middle of the list unnecessarily.
• Aligned Selection Indicator: The selection indicator behavior in the registry view has been standardized for consistency.
• Platform-Specific JetBrains Terminal Warnings: Compatibility warnings for JetBrains terminals now provide tailored recommendations for alternative terminal emulators based on the operating system (macOS, Windows, Linux).

Changelog

• packages/cli/src/ui/components/shared/SearchableList.tsx
  • Added availableTerminalHeight and scrollMode props to allow external control over list sizing and scrolling behavior.
  • Implemented computedMaxItemsToShow to calculate the number of visible items based on terminal height and reserved UI space.
  • Refactored scrollOffset logic to support a new 'keep-visible' scroll mode, ensuring the active item remains in view with minimal scrolling.
• packages/cli/src/ui/components/views/ExtensionRegistryView.tsx
  • Integrated useUIState to access the available terminal height.
  • Passed the availableTerminalHeight and scrollMode="keep-visible" props to the SearchableList component.
  • Adjusted the selection indicator to remove an extra space for better alignment.
• packages/core/src/utils/compatibility.test.ts
  • Added new test cases to verify that the JetBrains terminal warning message provides correct platform-specific recommendations for macOS, Windows, and Linux.
  • Updated an existing test to confirm the Windows-specific recommendation is included in the warning message.
• packages/core/src/utils/compatibility.ts
  • Modified the JetBrains terminal warning message to dynamically suggest alternative terminal emulators (e.g., iTerm2/Terminal.app for macOS, Windows Terminal for Windows, native terminal for Linux) based on the detected operating system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces responsiveness to terminal height for the extension explore list and adds a new 'keep-visible' scroll mode. While the height calculation is a valuable addition, the implementation of the 'keep-visible' scroll mode contains a logic error that prevents it from functioning as intended (it currently pins the selection to the bottom rather than allowing it to move freely within the window). Additionally, there is an inconsistency in the selection indicator between the registry view and the default list renderer, which contradicts the goal of aligning behavior.