fix(cli): use getDisplayString for manual model selection in dialog#19726
fix(cli): use getDisplayString for manual model selection in dialog#19726
Conversation
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user interface for manual model selection within the CLI's model dialog. By applying a dedicated display formatting function, it standardizes how manually entered model identifiers are presented, leading to a more polished and consistent visual experience for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to improve UI consistency in the model selection dialog by using the getDisplayString utility. The change correctly applies this function for the 'Manual' model selection display. However, the review identifies that this consistency improvement is incomplete, as other parts of the same component do not use this utility, leading to duplicated logic and potential future maintenance issues. A suggestion has been made to apply this function consistently throughout the component, reinforcing the rule about maintaining consistent UI behavior.
|
Thank you for linking an issue! This pull request has been automatically reopened. |
665a54b to
07c1579
Compare
07c1579 to
4a9b62a
Compare
|
Size Change: +106 B (0%) Total Size: 25.2 MB ℹ️ View Unchanged
|
Summary
Uses
getDisplayStringinstead of the raw value for the manual model selectionoption in
ModelDialog. This provides a consistent and polished string formatfor the manual model label in the dialog UI.
Details
Changed the string interpolation in
packages/cli/src/ui/components/ModelDialog.tsxto format the selected modelidentifier through
getDisplayStringwhen creating the title for the "Manual"list item.
Related Issues
Fixes #19728
How to Validate
/modelcommand).
selected model.
Pre-Merge Checklist