Skip to content

Comments

fix(cli): use getDisplayString for manual model selection in dialog#19726

Merged
sehoon38 merged 1 commit intomainfrom
fix/model-dialog-display-string
Feb 20, 2026
Merged

fix(cli): use getDisplayString for manual model selection in dialog#19726
sehoon38 merged 1 commit intomainfrom
fix/model-dialog-display-string

Conversation

@sehoon38
Copy link
Contributor

@sehoon38 sehoon38 commented Feb 20, 2026

Summary

Uses getDisplayString instead of the raw value for the manual model selection
option in ModelDialog. This provides a consistent and polished string format
for the manual model label in the dialog UI.

Details

Changed the string interpolation in
packages/cli/src/ui/components/ModelDialog.tsx to format the selected model
identifier through getDisplayString when creating the title for the "Manual"
list item.

Related Issues

Fixes #19728

How to Validate

  • Run the CLI and open the model selection dialog (e.g. with the /model
    command).
  • Select "Manual" and enter a model.
  • Verify that the title correctly displays the formatted string for the manually
    selected model.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested a review from a team as a code owner February 20, 2026 21:36
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 20, 2026

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 20, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface for manual model selection within the CLI's model dialog. By applying a dedicated display formatting function, it standardizes how manually entered model identifiers are presented, leading to a more polished and consistent visual experience for users.

Highlights

  • UI Consistency: Ensured that the display string for manually selected models in the ModelDialog is consistently formatted using getDisplayString, improving user experience.
Changelog
  • packages/cli/src/ui/components/ModelDialog.tsx
    • Updated the display logic for the "Manual" model selection option to use getDisplayString for formatting the selected model identifier.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve UI consistency in the model selection dialog by using the getDisplayString utility. The change correctly applies this function for the 'Manual' model selection display. However, the review identifies that this consistency improvement is incomplete, as other parts of the same component do not use this utility, leading to duplicated logic and potential future maintenance issues. A suggestion has been made to apply this function consistently throughout the component, reinforcing the rule about maintaining consistent UI behavior.

@gemini-cli gemini-cli bot reopened this Feb 20, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 20, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@sehoon38 sehoon38 force-pushed the fix/model-dialog-display-string branch from 665a54b to 07c1579 Compare February 20, 2026 21:48
@sehoon38 sehoon38 force-pushed the fix/model-dialog-display-string branch from 07c1579 to 4a9b62a Compare February 20, 2026 21:51
@sehoon38 sehoon38 enabled auto-merge February 20, 2026 21:53
@github-actions
Copy link

Size Change: +106 B (0%)

Total Size: 25.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.2 MB +106 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 20, 2026
@sehoon38 sehoon38 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit b48970d Feb 20, 2026
27 checks passed
@sehoon38 sehoon38 deleted the fix/model-dialog-display-string branch February 20, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model dialog displays raw model identifier instead of formatted string

2 participants