refactor(config): remove enablePromptCompletion from settings#19974
refactor(config): remove enablePromptCompletion from settings#19974
Conversation
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the CLI experience by completely eliminating the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully removes the enablePromptCompletion setting from the Gemini CLI. This involves removing the setting from the configuration parameters, the Config class in the core package, the settings schema, the JSON schema, and the UI settings dialog. The hooks useCommandCompletion and usePromptCompletion have been updated to hardcode the feature as disabled, effectively turning off AI-powered prompt suggestions. Documentation and tests have also been updated to reflect these changes. The refactor is thorough and maintains consistency across the monorepo.
|
Fixes #19975 |
|
Thank you for linking an issue! This pull request has been automatically reopened. |
|
Size Change: -760 B (0%) Total Size: 25.2 MB ℹ️ View Unchanged
|
9a5885a to
dc3143b
Compare
Summary
This PR removes the
enablePromptCompletionoption from the CLI configuration and settings dialog. The feature has been disabled by default as it's consuming a huge flash lite quota and will revisit this.Details
enablePromptCompletionfromConfigParametersandConfigclass inpackages/core.packages/cli's config builder.settingsSchema.tsandschemas/settings.schema.json.useCommandCompletionandusePromptCompletionhooks to forcefully disable prompt completion and removed dependencies on the old configuration getter.docs/reference/configuration.md,docs/cli/settings.md).SettingsDialogsnapshots and corresponding tests to remove the boolean setting.Related Issues
Fixes #19975
How to Validate
npm testto ensure all tests pass (particularlySettingsDialog.test.tsxand core configuration tests).npm run buildto verify the codebase compiles successfully.enablePromptCompletionis no longer present in~/.gemini/settings.jsonschemas./settings).Pre-Merge Checklist