Skip to content

Comments

refactor(config): remove enablePromptCompletion from settings#19974

Merged
bdmorgan merged 1 commit intomainfrom
remove-enable-prompt-completion
Feb 23, 2026
Merged

refactor(config): remove enablePromptCompletion from settings#19974
bdmorgan merged 1 commit intomainfrom
remove-enable-prompt-completion

Conversation

@sehoon38
Copy link
Contributor

@sehoon38 sehoon38 commented Feb 22, 2026

Summary

This PR removes the enablePromptCompletion option from the CLI configuration and settings dialog. The feature has been disabled by default as it's consuming a huge flash lite quota and will revisit this.

Details

  • Removed enablePromptCompletion from ConfigParameters and Config class in packages/core.
  • Removed mapping in packages/cli's config builder.
  • Removed the setting from settingsSchema.ts and schemas/settings.schema.json.
  • Updated useCommandCompletion and usePromptCompletion hooks to forcefully disable prompt completion and removed dependencies on the old configuration getter.
  • Removed references to the setting in configuration and cli documentation (docs/reference/configuration.md, docs/cli/settings.md).
  • Removed mention from the changelog to avoid confusion for users consulting past features.
  • Updated SettingsDialog snapshots and corresponding tests to remove the boolean setting.

Related Issues

Fixes #19975

How to Validate

  1. Run npm test to ensure all tests pass (particularly SettingsDialog.test.tsx and core configuration tests).
  2. Run npm run build to verify the codebase compiles successfully.
  3. Verify that enablePromptCompletion is no longer present in ~/.gemini/settings.json schemas.
  4. Launch the CLI and verify the "Enable Prompt Completion" setting is no longer displayed in the Settings dialog (accessed via /settings).

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested review from a team as code owners February 22, 2026 22:49
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 22, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 22, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 22, 2026

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the CLI experience by completely eliminating the enablePromptCompletion setting. This change was driven by the feature being internally disabled by default, aiming to reduce unnecessary clutter in the configuration and user interface, thereby preventing potential confusion for users. The removal encompasses all aspects of the feature, from core configuration definitions to UI elements and documentation, ensuring a clean and consistent state.

Highlights

  • Feature Removal: The enablePromptCompletion option has been entirely removed from the CLI configuration and settings dialog, as the feature was internally disabled by default.
  • Configuration Cleanup: All related code, documentation, and schema definitions for enablePromptCompletion have been purged across core and CLI packages, simplifying the codebase and user settings.
  • Testing and Snapshots: Associated tests and UI snapshots for the SettingsDialog and useCommandCompletion hook were updated to reflect the removal of the prompt completion setting.
Changelog
  • docs/cli/settings.md
    • Removed the 'Enable Prompt Completion' entry from the CLI settings documentation table.
  • docs/reference/configuration.md
    • Deleted the general.enablePromptCompletion section from the configuration reference documentation.
  • packages/cli/src/config/config.ts
    • Removed the enablePromptCompletion property from the loadCliConfig function's return object.
  • packages/cli/src/config/settingsSchema.ts
    • Eliminated the enablePromptCompletion definition from the SETTINGS_SCHEMA object.
  • packages/cli/src/config/settings_repro.test.ts
    • Removed the enablePromptCompletion property from the mock general settings in a test file.
  • packages/cli/src/test-utils/mockConfig.ts
    • Removed the getEnablePromptCompletion mock function from createMockConfig.
  • packages/cli/src/ui/components/SettingsDialog.test.tsx
    • Removed enablePromptCompletion from various mock configuration objects used in SettingsDialog tests.
  • packages/cli/src/ui/components/snapshots/SettingsDialog.test.tsx.snap
    • Updated multiple snapshots to remove the 'Enable Prompt Completion' line from the rendered settings dialog output.
  • packages/cli/src/ui/hooks/useCommandCompletion.test.tsx
    • Removed getEnablePromptCompletion from mock Config objects in useCommandCompletion tests.
  • packages/cli/src/ui/hooks/useCommandCompletion.tsx
    • Hardcoded isPromptCompletionEnabled to false.
    • Removed config from the dependency array of a useCallback hook.
    • Removed the enabled prop from the usePromptCompletion component call.
  • packages/cli/src/ui/hooks/usePromptCompletion.ts
    • Removed the enabled property from the UsePromptCompletionOptions interface.
    • Removed the enabled parameter from the usePromptCompletion function signature.
    • Hardcoded isPromptCompletionEnabled to false.
  • packages/core/src/config/config.ts
    • Removed enablePromptCompletion from the ConfigParameters interface.
    • Deleted the enablePromptCompletion private property from the Config class.
    • Removed the assignment of params.enablePromptCompletion in the Config class constructor.
    • Removed the getEnablePromptCompletion method from the Config class.
  • schemas/settings.schema.json
    • Removed the JSON schema definition for enablePromptCompletion.
Activity
  • Updated relevant documentation in docs/cli/settings.md and docs/reference/configuration.md.
  • Added/updated tests, specifically SettingsDialog.test.tsx and core configuration tests, to reflect the changes.
  • Verified that the codebase compiles successfully by running npm run build.
  • Confirmed that enablePromptCompletion is no longer present in ~/.gemini/settings.json schemas.
  • Validated that the 'Enable Prompt Completion' setting is no longer displayed in the CLI Settings dialog.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully removes the enablePromptCompletion setting from the Gemini CLI. This involves removing the setting from the configuration parameters, the Config class in the core package, the settings schema, the JSON schema, and the UI settings dialog. The hooks useCommandCompletion and usePromptCompletion have been updated to hardcode the feature as disabled, effectively turning off AI-powered prompt suggestions. Documentation and tests have also been updated to reflect these changes. The refactor is thorough and maintains consistency across the monorepo.

@sehoon38
Copy link
Contributor Author

Fixes #19975

@gemini-cli gemini-cli bot reopened this Feb 22, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 22, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 22, 2026
@github-actions
Copy link

github-actions bot commented Feb 22, 2026

Size Change: -760 B (0%)

Total Size: 25.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.2 MB -760 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@sehoon38 sehoon38 force-pushed the remove-enable-prompt-completion branch from 9a5885a to dc3143b Compare February 22, 2026 23:35
@sehoon38 sehoon38 added this pull request to the merge queue Feb 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2026
@bdmorgan bdmorgan merged commit c537fd5 into main Feb 23, 2026
26 of 27 checks passed
@bdmorgan bdmorgan deleted the remove-enable-prompt-completion branch February 23, 2026 00:10
SH20RAJ added a commit to SH20RAJ/gemini-cli that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove enablePromptCompletion from settings

3 participants