Skip to content

fix: YOLO mode still asking for plan approval in non-interactive mode #20212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theshloksschauhan wants to merge 1 commit into from
Closed

fix: YOLO mode still asking for plan approval in non-interactive mode #20212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/src/prompts/promptProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,8 @@ export class PromptProvider {
CodebaseInvestigatorAgent.name,
),
enableWriteTodosTool: enabledToolNames.has(WRITE_TODOS_TOOL_NAME),
enableEnterPlanModeTool: enabledToolNames.has(
ENTER_PLAN_MODE_TOOL_NAME,
),
enableEnterPlanModeTool:
enabledToolNames.has(ENTER_PLAN_MODE_TOOL_NAME) && !isYoloMode,
Comment on lines +163 to +164
Copy link
Contributor

@jerop jerop Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enter_plan_mode tool is not available in YOLO mode so this is redundant - #19570

enableGrep: enabledToolNames.has(GREP_TOOL_NAME),
enableGlob: enabledToolNames.has(GLOB_TOOL_NAME),
approvedPlan: approvedPlanPath
Expand Down Expand Up @@ -192,7 +191,7 @@ export class PromptProvider {
interactiveYoloMode: this.withSection(
'interactiveYoloMode',
() => true,
isYoloMode && interactiveMode,
isYoloMode,
Copy link
Contributor

@jerop jerop Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was very much intentional because it's used to define interactiveYoloMode

cc @jackwotherspoon

),
gitRepo: this.withSection(
'git',
Expand Down