Skip to content

Conversation

@kamja44
Copy link
Contributor

@kamja44 kamja44 commented Jul 16, 2025

TLDR

Replaced the TODO in server.test.ts with a full LoadCodeAssistResponse mock to better reflect the actual response structure and improve test coverage.

Dive Deeper

Reviewer Test Plan

This PR enhances test accuracy by mocking LoadCodeAssistResponse with realistic fields such as currentTier, allowedTiers, and cloudaicompanionProject, which are defined in packages/core/src/code_assist/types.ts.

By including representative data in the mock, we ensure the test:

Validates the output of loadCodeAssist

Confirms requestPost is called with the correct arguments

Detects contract changes early if API fields are modified or removed

This approach is consistent with other tests (e.g., onboardUser checks the name property), helping ensure future refactors remain safe.

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

closes #3433

kamja44 and others added 3 commits July 7, 2025 16:38
@kamja44 kamja44 requested a review from a team as a code owner July 16, 2025 07:16
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kamja44, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and accuracy of the CodeAssistServer tests by replacing a rudimentary mock response with a fully structured and realistic LoadCodeAssistResponse object. This change ensures that the tests more accurately reflect expected API behavior and can detect contract changes more effectively, improving overall test coverage and reliability.

Highlights

  • Test Enhancement: Replaced a basic TODO mock in packages/core/src/code_assist/server.test.ts with a detailed LoadCodeAssistResponse mock. This mock now includes realistic fields such as currentTier, allowedTiers, ineligibleTiers, and cloudaicompanionProject, improving the accuracy and coverage of the loadCodeAssist test.
  • Assertion Correction: Updated the test assertion from expect(response).toBe(mockResponse) to expect(response).toEqual(mockResponse). This change ensures proper deep equality checking for objects, which is crucial when comparing the structure and content of the mock response.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves a test by replacing a TODO with a detailed mock object for LoadCodeAssistResponse and makes the assertion more robust by using toEqual instead of toBe. The changes are good, but I've suggested one improvement to the mock object to use an enum member instead of a hardcoded string, which will enhance maintainability and type safety.

kamja44 and others added 2 commits July 16, 2025 16:19
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@gemini-cli gemini-cli bot added kind/bug priority/p2 Important but can be addressed in a future release. labels Jul 16, 2025
@NTaylorMullen NTaylorMullen enabled auto-merge July 17, 2025 22:55
@NTaylorMullen
Copy link
Collaborator

Thank you for the contribution @kamja44 !!

@NTaylorMullen NTaylorMullen added this pull request to the merge queue Jul 17, 2025
Merged via the queue into google-gemini:main with commit f0dc969 Jul 17, 2025
10 checks passed
skeshive pushed a commit that referenced this pull request Jul 18, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
galz10 pushed a commit that referenced this pull request Jul 22, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jkcinouye pushed a commit that referenced this pull request Jul 25, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
JunYang-tes pushed a commit to JunYang-tes/gemini-cli.nvim that referenced this pull request Aug 9, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
involvex pushed a commit to involvex/gemini-cli that referenced this pull request Sep 11, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
reconsumeralization pushed a commit to reconsumeralization/gemini-cli that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mock response for loadCodeAssist unit test

2 participants