-
Notifications
You must be signed in to change notification settings - Fork 11.1k
feat: Update GitHub workflow configurations #7004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request synchronizes the existing GitHub workflow configurations with the latest structure from the google-github-actions/run-gemini-cli repository. The primary goal is to align the CLI's workflow management with the updated upstream definitions. This involves introducing a new dispatch workflow and renaming several existing workflow files to more concise and consistent names, along with updating the corresponding references within the CLI's setup commands.
Highlights
- New Workflow File: Introduced a new workflow configuration file named
gemini-dispatch.ymlto handle routing within the GitHub workflows. - Workflow Renaming: Renamed the
gemini-cli.ymlworkflow file togemini-invoke.ymland updated its path togemini-assistant/gemini-invoke.yml. - Workflow Renaming: Renamed
gemini-issue-automated-triage.ymltogemini-triage.ymlfor brevity and consistency. - Workflow Renaming: Renamed
gemini-issue-scheduled-triage.ymltogemini-scheduled-triage.ymlfor brevity and consistency. - Workflow Renaming: Renamed
gemini-pr-review.ymltogemini-review.ymlfor brevity and consistency. - CLI Configuration Updates: Updated the
setupGithubCommand.test.tsandsetupGithubCommand.tsfiles to reflect the new names and paths of the GitHub workflow configurations, ensuring the CLI correctly references the synchronized workflows.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the GitHub workflow configurations to synchronize with the google-github-actions/run-gemini-cli repository. The changes involve renaming several workflow files and introducing a new gemini-dispatch.yml workflow. The modifications in setupGithubCommand.ts and its test file are consistent with these changes.
My review identifies one high-severity maintainability issue. The list of workflows is duplicated in the implementation and test files, creating a risk of them becoming out of sync. I've suggested a refactoring to centralize the workflow list, which will make the code more robust and easier to maintain.
341c0d4 to
7446567
Compare
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the GitHub workflow setup by centralizing the workflow paths into a GITHUB_WORKFLOW_PATHS constant, which is a good improvement for maintainability. However, I've identified a potential issue where using path.basename for destination files could lead to silent file overwrites if workflows in different subdirectories share the same filename. I've provided suggestions to preserve the directory structure when downloading workflows, which makes the process more robust. The corresponding tests also need updates to reflect this change, and I've included suggestions for those as well.
|
will merge once google-github-actions/run-gemini-cli#242 is merged |
This commit synchronizes the GitHub workflow configurations with the `google-github-actions/run-gemini-cli` repository. Key changes include: - Introduction of `gemini-dispatch.yml` to handle routing. - Renaming of `gemini-cli.yml` to `gemini-invoke.yml`. - Renaming of `gemini-issue-automated-triage.yml` to `gemini-triage.yml`. - Renaming of `gemini-issue-scheduled-triage.yml` to `gemini-scheduled-triage.yml`. - Renaming of `gemini-pr-review.yml` to `gemini-review.yml`. These updates ensure that the CLI is aligned with the latest workflow structure in the `google-github-actions/run-gemini-cli` repository.
7446567 to
ae86659
Compare
This commit synchronizes the GitHub workflow configurations with the
google-github-actions/run-gemini-clirepository.Key changes include:
gemini-dispatch.ymlto handle routing.gemini-cli.ymltogemini-invoke.yml.gemini-issue-automated-triage.ymltogemini-triage.yml.gemini-issue-scheduled-triage.ymltogemini-scheduled-triage.yml.gemini-pr-review.ymltogemini-review.yml.These updates ensure that the CLI is aligned with the latest workflow structure in the
google-github-actions/run-gemini-clirepository.