fix: unset GEMINI_API_KEY env var if empty

[gsquared94]

TLDR

If the GEMINI_API_KEY env var is set to empty string and Vertex AI env vars are set, then the GoogleGenAI client is initialized with {"apiKey":"","vertexai":true} which fails to use Vertex AI.

[API Error: {"error":{"code":401,"message":"Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.","status":"UNAUTHENTICATED","details":[{"@type":"type.googleapis.com/google.rpc.DebugInfo","detail":"Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project."},{"@type":"type.googleapis.com/google.rpc.ErrorInfo","reason":"CREDENTIALS_MISSING","domain":"googleapis.com","metadata":{"method":"google.cloud.aiplatform.v1beta1.PredictionService.CountTokens","service":"aiplatform.googleapis.com"}}]}}]

This is causing failures for Github Action runtimes.

Will submit a fix upstream, but handling it here directly.

Fixes: #5747

[gemini-code-assist]

Summary of Changes

Hello @gsquared94, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the GoogleGenAI client fails to authenticate when the GEMINI_API_KEY environment variable is set to an empty string, even if Vertex AI environment variables are correctly configured. The change ensures that if GEMINI_API_KEY is an empty string, it is unset, allowing the client to properly utilize Vertex AI credentials for authentication. This fix is crucial for preventing authentication failures in automated environments like GitHub Actions.

Highlights

• Environment Variable Handling: Implemented a check to explicitly unset the GEMINI_API_KEY environment variable if its value is an empty string. This prevents authentication errors when the GoogleGenAI client attempts to use an empty API key instead of relying on Vertex AI credentials, which was causing failures in GitHub Action runtimes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a critical issue where an empty GEMINI_API_KEY environment variable interferes with Vertex AI authentication. The proposed fix correctly unsets the variable to resolve this. My feedback includes a suggestion to make this fix more robust by handling cases where the API key might contain only whitespace, as this could lead to the same authentication problem.

[jerop]

thanks for this fix @gsquared94!