Fix @google/generative-ai/files paths #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
requested changes
May 28, 2024
| "browser": "./dist/files/index.mjs", | ||
| "module": "./dist/files/index.mjs", | ||
| "typings": "./dist/files/files.d.ts" | ||
| "main": "../dist/files/index.js", |
There was a problem hiding this comment.
Would this break the module imports?
There was a problem hiding this comment.
Module imports? I realized it might affect the rollup config as it gets paths from here, so I changed that.
There was a problem hiding this comment.
I tested this with tsconfig set to module:commonjs, module:node16 and in a vite bundler proejct and it seems to work in all cases.
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
This affects TypeScript users that are using "module: commonjs" or any other resolution that relies on the package.json in the files/ directory instead of on package.json exports.