Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the model field from the countTokens request payload #162

Merged
merged 10 commits into from
May 31, 2024
Merged

Remove the model field from the countTokens request payload #162

merged 10 commits into from
May 31, 2024

Conversation

DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented May 31, 2024 •
edited
Loading

The model isn't required as part of the countTokens request, as it's already part of the request URL.

  • Unit tests pass.
  • Integration tests pass.

@DellaBitta DellaBitta requested a review from hsubox76 May 31, 2024 14:52
@DellaBitta DellaBitta marked this pull request as ready for review May 31, 2024 18:36
@DellaBitta DellaBitta merged commit 1440a05 into main May 31, 2024
4 checks passed
@DellaBitta DellaBitta deleted the ddb-remove-model-count-tokens-payload branch May 31, 2024 18:36
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 10, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 10, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 10, 2024
Closed
@leoo1992 leoo1992 mentioned this pull request Jul 10, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 18, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 18, 2024
Closed
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 18, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Jul 19, 2024
Merged
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 21, 2024
Closed
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 23, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 23, 2024
Closed
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 23, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 23, 2024
Open
This was referenced Aug 1, 2024
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 6, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Aug 6, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 6, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 15, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 15, 2024
Open
@paulorezende007 paulorezende007 mentioned this pull request Aug 21, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 25, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 4, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 7, 2024
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 11, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @hsubox76