Fix a type definitions for response_schema and function calling #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the type definitions of response schema for JSON output and function calling parameters.
Background
The current type definition cannot represent all the schemas defined in the API. For example, the following schema definition results in a type error.
Problem
The type definition of
Schema
does not match the API.generative-ai-js/packages/main/types/function-calling.ts
Lines 108 to 130 in 5739e2a
items
andproperties
should be theSchema
itself.FunctionDeclarationSchema
has noitems
parameter.generative-ai-js/packages/main/types/function-calling.ts
Lines 136 to 145 in 5739e2a
Schema definitions
The type definitions refer to the following specifications:
Both parameters refer to the Schema object:
How Has This Been Tested?
Added a test case
References
responseSchema
togenerationConfig
#158