Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move node samples to top level, restore web samples #206

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Move node samples to top level, restore web samples #206

merged 3 commits into from
Jul 11, 2024

Conversation

hsubox76
Copy link
Collaborator

  • Move node/ samples to top level of samples/ dir to conform to expected pattern.
  • Restored samples/web/ as a subdirectory, as some guides still link to it.
  • Update top-level READMEs on how to run samples
  • Update samples README with a note on how to get to web samples

@hsubox76 hsubox76 marked this pull request as ready for review July 11, 2024 17:20
@hsubox76 hsubox76 requested a review from dlarocque July 11, 2024 17:20
dlarocque
dlarocque approved these changes Jul 11, 2024
View reviewed changes
samples/web/chat.html Outdated
<!doctype html>
<!--
* @license
* Copyright 2023 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: update to 2024 in all files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hsubox76 hsubox76 merged commit 02a9a26 into main Jul 11, 2024
8 checks passed
@hsubox76 hsubox76 deleted the ch-reorganize branch July 11, 2024 18:44
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 6, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Aug 6, 2024
Merged
@nestorzamili nestorzamili mentioned this pull request Aug 6, 2024
Merged
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Aug 6, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 6, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 15, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Aug 15, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 15, 2024
Open
@Harshu0132 Harshu0132 mentioned this pull request Aug 16, 2024
Open
@paulorezende007 paulorezende007 mentioned this pull request Aug 21, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 25, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Aug 26, 2024
Closed
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 4, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 4, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Sep 4, 2024
Closed
@Harshu0132 Harshu0132 mentioned this pull request Sep 6, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 7, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Sep 7, 2024
Closed
@diaz-rigo diaz-rigo mentioned this pull request Sep 9, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 11, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 19, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 20, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 21, 2024
Open
@DakineMI DakineMI mentioned this pull request Sep 21, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 22, 2024
Open
@DakineMI DakineMI mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 23, 2024
Open
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 24, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Sep 27, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 3, 2024
Open
@11-Wanissha 11-Wanissha mentioned this pull request Oct 4, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 4, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Oct 4, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Oct 14, 2024
Open
@shino-337 shino-337 mentioned this pull request Oct 20, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 28, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Oct 31, 2024
Open
@oMaestro174 oMaestro174 mentioned this pull request Nov 9, 2024
Open
@Cee-Jay-Err0r Cee-Jay-Err0r mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @dlarocque