Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response_schema parameter #302

Merged
merged 15 commits into from
May 3, 2024

Conversation

shilpakancharla
Copy link
Collaborator

@shilpakancharla shilpakancharla commented Apr 25, 2024

Description of the change

Add a parameter response_schema to accept JSON schema to GenerationConfig.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 25, 2024
shilpakancharla and others added 2 commits April 29, 2024 06:31
Change-Id: I90e9c4218f041687c3b50e620305b6eff09b650a
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, please add a test or two.

MarkDaoust
MarkDaoust previously approved these changes May 3, 2024
@MarkDaoust MarkDaoust merged commit a96feda into google-gemini:main May 3, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants