Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy test cases over for new responder.py #303

Merged

Conversation

shilpakancharla
Copy link
Collaborator

Description of the change

Check if the current test cases that are in test_content.py are able to pass with the code copied over into responder.py. Created a new test file called test_responder.py.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 25, 2024
@@ -0,0 +1,467 @@
# -*- coding: utf-8 -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this already created in #289 ?

Maybe you need to merge or rebase?

Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember, you can run the tests locally with python -m unittest.

Change-Id: I55e2d72d7f27eb2c0c89285de7b6fab17d9a20f0
Change-Id: I450b0be8a48c40e910c1c7fab6854f9659704dc6
@MarkDaoust MarkDaoust merged commit 3a9c286 into google-gemini:main Apr 26, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants