Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching cURL sample #455

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Caching cURL sample #455

merged 9 commits into from
Jul 24, 2024

Conversation

Giom-V
Copy link
Contributor

@Giom-V Giom-V commented Jul 11, 2024

Description of the change

Adding a new sample for the caching using cURL

Motivation

To explain how to use caching with cURL

Type of change

Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Giom-V Giom-V changed the title Caching curl sample Caching cURL sample Jul 11, 2024
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jul 11, 2024
MarkDaoust
MarkDaoust requested changes Jul 11, 2024
View reviewed changes
samples/rest/caching.sh Outdated Show resolved Hide resolved
samples/rest/caching.sh Outdated Show resolved Hide resolved
Giom-V
Giom-V commented Jul 12, 2024
View reviewed changes
samples/rest/caching.sh Outdated Show resolved Hide resolved
@Giom-V Giom-V requested a review from MarkDaoust July 12, 2024 14:42
Giom-V and others added 4 commits July 12, 2024 14:02
@Giom-V
cache_generate_content region tag
be366ba
@Giom-V
Moving the generation in cache_create
e18ea51
@MarkDaoust
Merge branch 'main' into caching_curl_sample
84b1a9e 
Change-Id: I5ba61707c8ad132709105f97d96df6edd54415c4
@MarkDaoust
Fix
eb02d25 
Change-Id: If09a99b8f4637bae509b32469b0cd9fd9ec60024
@MarkDaoust MarkDaoust merged commit 84db061 into google-gemini:main Jul 24, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giom-V @MarkDaoust