Always read back the deployment to get metadata #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
commented
Dec 15, 2022
sethvargo
force-pushed
the
sethvargo/readback
branch
5 times, most recently
from
26784fd to
7070ef3
Compare
This fixes an issue where --no-promote does not include all the URL information. Closes #288
sethvargo
force-pushed
the
sethvargo/readback
branch
from
7070ef3 to
6665451
Compare
verbanicm
approved these changes
Dec 15, 2022
Merged
sethvargo
pushed a commit
that referenced
this pull request
Dec 16, 2022
## What's Changed * docs: update readme examples to use v1 by @ruxandrafed in #282 * Remove unused stub by @sethvargo in #283 * chore(deps): bump sinon from 14.0.2 to 15.0.0 by @dependabot in #284 * chore(deps): bump qs and express in /example-app by @dependabot in #285 * Update deps and CI by @sethvargo in #286 * Ignore the default service in cleanup by @sethvargo in #287 * Only set metrics in the current step by @sethvargo in #289 * Always read back the deployment to get metadata by @sethvargo in #290 * Add support for custom gcloud components and versions by @sethvargo in #291 ## New Contributors * @ruxandrafed made their first contribution in #282 **Full Changelog**: v1.0.0...bdce19e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where --no-promote does not include all the URL information.
Closes #288