Skip to content

feat: add command substitution security warning #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerop wants to merge 1 commit into from
Closed

feat: add command substitution security warning #290

jerop wants to merge 1 commit into from

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Sep 17, 2025 •
edited
Loading

Adds a security warning to all Gemini CLI workflow prompts, instructing the model to avoid using command substitution features like $(...), <(...), or >(...) in shell commands.

This is a preventative measure to avoid errors where the Gemini CLI rejects commands that use command substitution for security reasons. This change makes the security constraints of the tool explicit to the model.

Fixes #174

@jerop jerop requested review from a team as code owners September 17, 2025 18:41
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

Fixing issue in #293

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

fyi using this PR to test out the new auth validation

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop jerop force-pushed the feat/add-security-warning-to-workflows branch from 6c98a3c to 8c8a087 Compare September 17, 2025 21:34
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

2 similar comments
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop jerop force-pushed the feat/add-security-warning-to-workflows branch from 8c8a087 to 2a9ad72 Compare September 17, 2025 22:22
@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

1 similar comment
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 18, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop
Copy link
Contributor Author

jerop commented Sep 18, 2025

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 18, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 18, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop
feat: add command substitution security warning
1d14bfe 
Adds a security warning to all Gemini CLI workflow prompts, instructing the model to avoid using command substitution features like `$(...)`, `<(...)`, or `>(...)` in shell commands.

This is a preventative measure to avoid errors where the Gemini CLI rejects commands that use command substitution for security reasons. This change makes the security constraints of the tool explicit to the model.
@jerop jerop force-pushed the feat/add-security-warning-to-workflows branch from 2a9ad72 to 1d14bfe Compare September 18, 2025 14:00
@jerop
Copy link
Contributor Author

jerop commented Sep 18, 2025

@gemini-cli /review

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 18, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Sep 18, 2025

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

@jerop jerop closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@R2wenD2 R2wenD2 Awaiting requested review from R2wenD2 R2wenD2 is a code owner automatically assigned from google-github-actions/maintainers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

@NTaylorMullen NTaylorMullen Awaiting requested review from NTaylorMullen NTaylorMullen is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

@HassanJasim HassanJasim Awaiting requested review from HassanJasim HassanJasim is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Command substitution using $(), <(), or >() is not allowed

1 participant

@jerop