-
Notifications
You must be signed in to change notification settings - Fork 184
Add GOOGLE_GENAI_USE_VERTEXAI variable setting to make workflow work #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Huan Li <huan@chatie.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automatic configuration of the GOOGLE_GENAI_USE_VERTEXAI variable during the Workload Identity Federation setup process. This ensures that workflows using Vertex AI authentication will have the required variable set correctly.
- Adds
GOOGLE_GENAI_USE_VERTEXAIvariable to the automated GitHub variable setup when theghCLI is available
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gh variable set GOOGLE_CLOUD_PROJECT --body "${GOOGLE_CLOUD_PROJECT}" --repo "${GITHUB_REPO}" | ||
| gh variable set GOOGLE_CLOUD_LOCATION --body "${GOOGLE_CLOUD_LOCATION}" --repo "${GITHUB_REPO}" | ||
| gh variable set SERVICE_ACCOUNT_EMAIL --body "${SERVICE_ACCOUNT_EMAIL}" --repo "${GITHUB_REPO}" | ||
| gh variable set GOOGLE_GENAI_USE_VERTEXAI --body "true" --repo "${GITHUB_REPO}" |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new GOOGLE_GENAI_USE_VERTEXAI variable is set automatically when gh CLI is available, but it's not included in the manual setup instructions in the else block (lines 462-477). Users without the gh CLI won't know to set this variable manually. Consider adding documentation for this variable in the else block, similar to the other variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved.
…manual setup Co-authored-by: huan <1361891+huan@users.noreply.github.com>
Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions
|
@gemini-cli /review |
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This Pull Request introduces a necessary fix by adding the GOOGLE_GENAI_USE_VERTEXAI variable to the setup script, which resolves an authentication error. The change is well-contained and directly addresses the reported issue.
🔍 General Feedback
- The inclusion of
echostatements for the newly set variable provides good visibility into the script's actions. - The overall approach aligns with the existing script's structure and conventions.
| echo "" | ||
| echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI" | ||
| echo " Variable Value: true" | ||
| echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Consider clarifying how to 'use GOOGLE_GENAI_USE_GCA'. The current phrasing might imply setting GOOGLE_GENAI_USE_GCA to true, but it's not explicitly stated as it is for GOOGLE_GENAI_USE_VERTEXAI. Perhaps something like 'or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist'.
| echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)" | |
| echo " (Set to 'true' to use Vertex AI, or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist)" |
Fix the action error:
See: https://github.com/huan/ai-student-assistant/actions/runs/19178287968/job/54828468408#step:5:410
I ran into this issue today at DevFest Workshop Secure GitHub Workflow with Gemini CLI by Tianzi Cai & Rody Davis, Google.