Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add go code #1

Merged
merged 4 commits into from
Jul 25, 2023
Merged

feat: add go code #1

merged 4 commits into from
Jul 25, 2023

Conversation

sailorlqh
Copy link
Contributor

Add initial code for formatting and sending messages to google chat.

Will have different PRs for releasing the go binary, and action.yml for the github action.

@sailorlqh sailorlqh requested a review from verbanicm July 19, 2023 21:55
@verbanicm verbanicm requested a review from sethvargo July 19, 2023 21:58
sethvargo
sethvargo reviewed Jul 20, 2023
View reviewed changes
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
@sailorlqh sailorlqh force-pushed the sailorlqh/add_init_code branch from faa78e7 to f2d510a Compare July 20, 2023 05:31
verbanicm
verbanicm reviewed Jul 20, 2023
View reviewed changes
src/main.go Outdated Show resolved Hide resolved
verbanicm
verbanicm reviewed Jul 20, 2023
View reviewed changes
src/main.go Outdated Show resolved Hide resolved
verbanicm
verbanicm reviewed Jul 20, 2023
View reviewed changes
src/main.go Outdated Show resolved Hide resolved
sethvargo
sethvargo reviewed Jul 20, 2023
View reviewed changes
src/main.go Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
src/main_test.go Outdated Show resolved Hide resolved
verbanicm
verbanicm reviewed Jul 20, 2023
View reviewed changes
src/main.go Show resolved Hide resolved
@sailorlqh sailorlqh requested review from sethvargo and verbanicm July 20, 2023 21:17
sethvargo
sethvargo approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the remaining things are nits, but let's make sure to either create issues or do a fast-follow PR with the changes.

src/main.go Show resolved Hide resolved
src/main.go Show resolved Hide resolved
src/main.go Show resolved Hide resolved
src/main.go Show resolved Hide resolved
@sailorlqh sailorlqh mentioned this pull request Jul 25, 2023
Closed
@sailorlqh sailorlqh merged commit 1c48c9a into main Jul 25, 2023
@sethvargo sethvargo deleted the sailorlqh/add_init_code branch July 25, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbanicm verbanicm verbanicm approved these changes

@sethvargo sethvargo sethvargo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sailorlqh @sethvargo @verbanicm