Suggestion to fix missing GCloud SDK authentication #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I'm trying to bump up
google-github-actions/setup-gcloud
to v1, and found that there is one deleted feature that was not deprecated in the v0 README.Expected Behavior (v0)
v0 authenticates GCloud SDK if
GOOGLE_GHA_CREDS_PATH
env var is set.google-github-actions/auth
sets this env var (I've checked both v1 and v0), so we use these actions like below:Actual Behavior (v1.0.0)
According to the changeset of v1.0.0, v1.0.0 release removed this automatic authentication feature.
I haven't confirmed yet, but we probably need a snippet like below to run authentication manually:
Discussion I want to hold here
I hope we can bring this automatic authentication feature back in v1 release. Could you consider it when you have time?
Or if it is necessary to remove this code, I hope we users have enough document in README.md or somewhere, to find how we need to authenticate GCloud SDK.
Thanks for reading my PR! 🙌