Fixes for proper error handling on calls to the Matter SDK. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pierredelisle
commented
Nov 14, 2022
pierredelisle
commented
- Replaced call to chipController.openPairingWindowWithPin with openPairingWindowWithPinCallback. The former did support callback via setCompletionListener().
- Wait for successful completion of "openPairingWindow" before calling the GPS shareDevice() API.
- Cleaned up logs with a standardized "ShareDevice: " prefix for all multi-admin related log messages.
- Fixed error handling and processing of the shareDevice Status LiveData.
- Fixed typo in HomeViewModel: "com.google.android.gms.home.matter.EXTRA_DEVICE_TYPE" (was "com.google.android.gms.home.matter.EXTRA_DEVICE_TYPE").
- Replaced call to chipController.openPairingWindowWithPin with openPairingWindowWithPinCallback. The former did support callback via setCompletionListener(). - Wait for successful completion of "openPairingWindow" before calling the GPS shareDevice() API. - Cleaned up logs with a standardized "ShareDevice: " prefix for all multi-admin related log messages. - Fixed error handling and processing of the shareDevice Status LiveData. - Fixed typo in HomeViewModel: "com.google.android.gms.home.matter.EXTRA_DEVICE_TYPE" (was "com.google.android.gms.home.matter.EXTRA_DEVICE_TYPE").
…ed that background work is being performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.