Adds a new developer utility to discover commissionable Matter devices. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pierredelisle
commented
Jan 4, 2023
pierredelisle
commented
- new screen/commissionable package where all that work is implemented.
- Commissionable{Fragment|VewModel} to support the new commissionable screen.
- Set of MatterBeacon* classes provide the infrastructure to support a variety of matter beacons
- Packages ble, mdns, and wifi provide the transport specific scanning code.
- AndroidManifest.xml: New set of permissions for BLE and WiFi scanning.
- ChipClient.kt, GmsCoreServiceResolver.kt: Replaced Android's NsdManagerServiceResolver with one that leverages GMSCore mDNS discovery API.
- Espresso test to verify the behavior of the CommissionableFragment.
- new screen/commissionable package where all that work is implemented.
- Commissionable{Fragment|VewModel} to support the new commissionable screen.
- Set of MatterBeacon* classes provide the infrastructure to support a variety of matter beacons
- Packages ble, mdns, and wifi provide the transport specific scanning code.
- AndroidManifest.xml: New set of permissions for BLE and WiFi scanning.
- ChipClient.kt, GmsCoreServiceResolver.kt: Replaced Android's NsdManagerServiceResolver with one that leverages GMSCore mDNS discovery API.
- Espresso test to verify the behavior of the CommissionableFragment.
- Revert back to NsdManagerServiceResolver (GmsCoreServiceResolver fails with serviceType not supported) - Fix typo in CommissionableViewModel.kt. And - Properly handle commissioning exception by calling GMSCore sendCommissioningError()
- Revert back to NsdManagerServiceResolver (GmsCoreServiceResolver fails with serviceType not supported) - Fix typo in CommissionableViewModel.kt. And - Properly handle commissioning exception by calling GMSCore sendCommissioningError()
- So that it works properly whether or not the "Codelab Dialog" is shown when the app is launched. - Fixed typos (copy/paste) in the producers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.