Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a DeviceAttestationDelegate #92

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

pierredelisle
Copy link
Contributor

With the DeviceAttestationDelegate, device attestation failure is simply ignored. Commissioning non-test Matter devices will now work.

Fix for issues: #83 #86

With the DeviceAttestationDelegate, device attestation failure is simply ignored. A warning is logged.
Commissioning non-test Matter devices will now work.
@mauimauer mauimauer merged commit 0eb3c6d into main Mar 1, 2023
@pierredelisle pierredelisle deleted the pierred/device-attestation branch March 1, 2023 22:08
@TadashiSatoo
Copy link

TadashiSatoo commented Mar 2, 2023

@pierredelisle
Thank you for PR.
But the problem is not fixed in my environment.
#83
Does not work setDeviceAttestationDelegate.

I check the break point.But it's not stopped.
スクリーンショット 2023-03-02 15 28 22

I attached log.
log.txt

setDeviceAttestationDelegate() seem to be in error

Missing DeviceAttestationVerifier configuration at DeviceCommissioner init: using global default, consider passing one in CommissionerInitParams.

Thank you for confirming.

@pierredelisle
Copy link
Contributor Author

@TadashiSatoo Please provide complete logs so we can investigate.

@TadashiSatoo
Copy link

@pierredelisle
Thank you for reply.
Sorry...The information I provided was not completed.
I provide debug information.
Could you confirm it.

  • GHSAFM version

  • Which device you used to test, and the release version of its firmware.

    • Google Pixel5 : Android13(latest firmware)
    • nRF52840 DK bord.(Nordic)
  • Google Play Services version

    • com.google.android.gms.optional_home [230617065] [23.06.17 (100400-0)] [Download:00000141/dl-Home.optional_230617100400.apk] [download:/Home.optional/230617100400:Home.optional:230617100400]
  • Phone log
    logs.txt

  • Device log
    device_logs.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants