Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Storable instance for Float32 #543

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

cyntsh
Copy link
Contributor

@cyntsh cyntsh commented Jun 3, 2021

For example, this allows the casting from Word8 instances to Float32 when reading floats from file.

Co-authored-by: Zoe Chen zoe.chenzizhao@gmail.com
Co-authored-by: Adam Paszke apaszke@google.com
Co-authored-by: David Duvenaud duvenaud@gmail.com

@google-cla
Copy link

google-cla bot commented Jun 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 3, 2021
@google-cla
Copy link

google-cla bot commented Jun 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@apaszke
Copy link
Collaborator

apaszke commented Jun 7, 2021

Looks great, thank you! It seems like you have a few comments with different values in the "author" field which confuses the CLA bot. Could you please try squashing them and making sure that the author field is correct?

You could also try adding Zoe as a coauthor by adding this at the bottom of your commit message:

Co-authored-by: Zoe Chen <zoe.chenzizhao@gmail.com>

@cyntsh
Copy link
Contributor Author

cyntsh commented Jun 7, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

cyntsh and others added 2 commits June 7, 2021 18:10
Co-authored-by: Zoe Chen <zoe.chenzizhao@gmail.com>
Co-authored-by: Adam Paszke <apaszke@google.com>
Co-authored-by: David Duvenaud <duvenaud@gmail.com>
Co-authored-by: Zoe Chen <zoe.chenzizhao@gmail.com>
Co-authored-by: Adam Paszke <apaszke@google.com>
Co-authored-by: David Duvenaud <duvenaud@gmail.com>
@google-cla
Copy link

google-cla bot commented Jun 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cyntsh
Copy link
Contributor Author

cyntsh commented Jun 7, 2021

Alright, I've rebased all the commits, thanks for the pointer!
(@chenzizhao @apaszke @duvenaud I added you as co-authors, googlebot just needs your consent.)

@chenzizhao
Copy link
Contributor

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@apaszke
Copy link
Collaborator

apaszke commented Jun 8, 2021

@chenzizhao have you signed the CLA? It looks like we need constant from @duvenaud, but I can see a "missing CLA" error next to you @chenzizhao

@chenzizhao
Copy link
Contributor

Sorry, I just signed CLA -- has the status changed on your end?

@duvenaud
Copy link
Contributor

duvenaud commented Jun 9, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 9, 2021
@apaszke apaszke merged commit bdb157b into google-research:main Jun 9, 2021
@apaszke
Copy link
Collaborator

apaszke commented Jun 9, 2021

Thanks everyone! Hopefully the CLA bot will not be quite as annoying in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants