Added table index sets, and used them to make fft types enforce power… #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvenaud
changed the title
apaszke
approved these changes
Apr 25, 2022
|
Okay, great, your PR unblocked me, and the FFT was already passing tests. I added a few comments and added FFT back to the tests. I think it's ready to merge now. |
|
Thanks, David! |
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s-of-2 sizes.
This was very satisfying. Now we can programmatically iterate over tables of arbitrary dimension, which let me clean up the CTC and FFT examples.
The FFT inner loop also now avoids some unnecessary discrete math. The FFT code now typechecks and passes tests again, thanks to #877!
There are further enhancements that can be made to the FFT example once we can handle incrementing and decrementing
Nats at the type level.