Skip to content

Commit

Permalink
CEA608 - Add space when handling mid-row codes
Browse files Browse the repository at this point in the history
Issue: #3906

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=200526335
  • Loading branch information
ojw28 committed Jun 18, 2018
1 parent 9ecf959 commit 3570232
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
changes ([#4276](https://github.com/google/ExoPlayer/issues/4276)).
* Fix `MediaCodec.native_setSurface` crash on Moto C
([#4315](https://github.com/google/ExoPlayer/issues/4315)).
* Fix missing whitespace in CEA-608
([#3906](https://github.com/google/ExoPlayer/issues/3906)).
* Set `METADATA_KEY_TITLE` on media descriptions
((#4292)[https://github.com/google/ExoPlayer/issues/4292]).
([#4292](https://github.com/google/ExoPlayer/issues/4292)).
* Allow apps to register custom MIME types
([#4264](https://github.com/google/ExoPlayer/issues/4264)).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ private boolean handleCtrl(byte cc1, byte cc2) {
private void handleMidrowCtrl(byte cc2) {
// TODO: support the extended styles (i.e. backgrounds and transparencies)

// A midrow control code advances the cursor.
currentCueBuilder.append(' ');

// cc2 - 0|0|1|0|ATRBT|U
// ATRBT is the 3-byte encoded attribute, and U is the underline toggle
boolean isUnderlined = (cc2 & 0x01) == 0x01;
Expand Down

0 comments on commit 3570232

Please sign in to comment.