Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExoPlayer2 throws RuntimeException before api level 21 #1820

Closed
garywzh opened this issue Sep 14, 2016 · 0 comments
Closed

ExoPlayer2 throws RuntimeException before api level 21 #1820

garywzh opened this issue Sep 14, 2016 · 0 comments
Assignees
@ojw28
Labels
bug

Comments

@garywzh
Copy link

garywzh commented Sep 14, 2016

FrameLayout before Lollipop doesn't hava the 4th constructor.

So in SimpleExoPlayerView

calling super(context, attrs, defStyleAttr, defStyleRes);

will get NoSuchMethodError before api level 21
@ojw28 ojw28 added the bug label Sep 14, 2016
@ojw28 ojw28 self-assigned this Sep 14, 2016
ojw28 added a commit that referenced this issue Sep 14, 2016
@ojw28
Fix crash on pre-api-21 devices.
ab49425 
The four-arg constructor didn't exist in ViewGroup for
earlier API levels. I think it can probably be safely
omitted, unless you know otherwise?

Issue: #1820

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133156975
@ojw28 ojw28 closed this as completed Sep 14, 2016
@ojw28 ojw28 mentioned this issue Sep 14, 2016
Merged
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ojw28 @garywzh