-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExoPlayerImplInternal: NPE #2330
Comments
It would be helpful if you could include all of the information requested in the issue template. For example a proper bug report and (more importantly in this case) the specific version of ExoPlayer that this reproduces with. |
For the final paragraph: If you provide complete information and can demonstrate that particular issues affect more than a single media file, then we'll investigate and put fixes in place. Without the information requested in the issue template we're not able to do this. |
I can reproduce the problem. It's not helpful that both audio files include a text track that's approximately (not exactly) twice as long as the audio. This is why the content appears to have a duration of around 45 minutes when the actual audio is only about 22 minutes long. VLC also ends up with the duration being way too long for the same reason. This is also the reason why the player gets confused and stuck in the buffering state. The actual stack trace that follows when you manually skip to the next entry in the playlist is a bug, which we will use this issue to track. |
Sorry for the incomplete report. |
We'll push a fix for the stack trace shortly, which will allow the user to advance to the next item without failure. We'll also push a fix for an issue that prevents backward seeking within the same item once in the "stuck buffering" state. The stuck buffering state itself is due to the media containing an incorrect duration for the text track that's for some reason present. Not getting stuck in this case is tracked by #1874, but when that issue is fixed the behavior will be to play out about 20 minutes of silence up to the stated duration of the media. This is the technically correct thing to do. The only way to avoid this is to fix the media itself. |
@ojw28 #1874 issue happens only on particular set of devices when we try to play videos(in playlist) stored in local storage of device. Also, it happens only when moving from 1st to 2nd track in playlist and not otherwise. Any quick workaround like suggested by you in previous comment of always allowing media to play for stated duration can be implemented? |
Also clear the playingPeriodHolder in the case the renderers are being disabled. This is required to ensure that setPlayingPeriodHolder isn't turned into a no-op, which will break the seek. Issue: #2330 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144635220
The failure is fixed in
Either way, a user isn't going to want to sit around for 20 minutes waiting for the next item to start. Fixing #1874 is quite technically difficult; it's not a quick workaround. We'll follow up on that issue in due course, but it's not going to be a quick thing. |
I received an exoplayer error which was quite hard to reproduce. I'll send the files separately via mail.
To reproduce the issue, follow these steps:
I generally receive many complaints by users about ExoPlayer. A lot of media out there has problems with metadata so it might make sense to try to play these non compliant files anyway. Like in #2239.
The text was updated successfully, but these errors were encountered: