Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS - Format adapts at start even when a fixed track selection is used #2353

Closed
ojw28 opened this issue Jan 20, 2017 · 5 comments
Closed

HLS - Format adapts at start even when a fixed track selection is used #2353

ojw28 opened this issue Jan 20, 2017 · 5 comments
Assignees
Labels

Comments

@ojw28
Copy link
Contributor

ojw28 commented Jan 20, 2017

See #2343. For HLS playback in V2 we always start playing out the first track in the master playlist, even if it's not present at all in the track selection. For example if the track selector has chosen a different track as a fixed track selection.

We should not start playing out the first track in the case that it's not present in the track selection at all. Aside from being confusing, it could cause failures (e.g. if the first track in the master playlist happens to be one that exceeds device capabilities).

@ojw28 ojw28 added the bug label Jan 20, 2017
ojw28 pushed a commit that referenced this issue Feb 23, 2017
This avoids breaking the player if the first variant is not
supported by the device.

Issue:#2353

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=148025791
@b95505017
Copy link
Contributor

So after v2.3.0 released, is InitializationTrackSelection in HlsChunkSource still need?

@ojw28
Copy link
Contributor Author

ojw28 commented Mar 22, 2017

This is now fixed. Yes, it's still needed internally.

@ojw28 ojw28 closed this as completed Mar 22, 2017
@b95505017
Copy link
Contributor

b95505017 commented Mar 22, 2017

I'm confused a little bit, how does the InitializationTrackSelection interact with the track selection from outside after v2.3.0?
If we want player always start from the format in the middle of the bandwidth in playlist. (e.g. 240p, 360p, 720p, always start from 360p) Use track selection from outside is enough or we still have to modify InitializationTrackSelection?

@ojw28
Copy link
Contributor Author

ojw28 commented Mar 22, 2017

Outside is sufficient to get the format you want. Internally we may request a fraction of a segment from some other format, determined by InitializationTrackSelection, but any media loaded as a result wont be played out.

@Prawez
Copy link

Prawez commented Jul 10, 2017

Hi There,

I am using latest version of exoplayer and it is working perfectly fine at our end. However I have faced issue to show different bit rates from HLS video file. I am always getting current bit rate profile. I want to show all bit rates profile and allow user to chose any one of them.

Please assist me how I could achieve this? Any help really appricated.

@google google locked and limited conversation to collaborators Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants