Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS: Add factory for Extractors #2748

Closed
IanDBird opened this issue Apr 28, 2017 · 2 comments
Closed

HLS: Add factory for Extractors #2748

IanDBird opened this issue Apr 28, 2017 · 2 comments
Assignees
@AquilesCanta
Labels
enhancement

Comments

@IanDBird
Copy link
Contributor

In ExoPlayer v2, the HlsMediaChunk class is responsible for constructing what extractor is required for a given format (createExtractor). This means that HLS handling is tightly coupled to what extractors are used.

Since applications are capable of creating their own extractors (e.g. their own TsExtractor) it would be useful to allow these to be passed into the HLS implementation to be used. This would require the HlsMediaSource accepting an extractor factory which could then be created by the application.
@stari4ek
Copy link

stari4ek commented Aug 3, 2017

this is the only way to bypass FLAG_ALLOW_NON_IDR_KEYFRAMES, FLAG_DETECT_ACCESS_UNITS which can be required for some HLS streams.
HlsMediaChunk does not provide any other easy way to extend. It's final and pretty complex to provide own variant

stari4ek added a commit to stari4ek/ExoPlayer that referenced this issue Aug 4, 2017
@stari4ek
workaround for google#2748
57a4e4c
@ojw28 ojw28 mentioned this issue Aug 4, 2017
Closed
@AquilesCanta AquilesCanta mentioned this issue Aug 9, 2017
Closed
@AquilesCanta AquilesCanta mentioned this issue Oct 18, 2017
Closed
ojw28 pushed a commit that referenced this issue Oct 19, 2017
@AquilesCanta @ojw28
Allow extractor injection for HLS
2cfc478 
Issue:#2748

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172726367
stari4ek added a commit to stari4ek/ExoPlayer that referenced this issue Oct 19, 2017
@stari4ek
adopt workaround for google#2748 for ExoPlayer 2.5.4
f900dcf
@AquilesCanta
Copy link
Contributor

Please give it a try and let us know if it works for you.

ojw28 pushed a commit that referenced this issue Nov 13, 2017
@AquilesCanta @ojw28
Fix DefaultHlsExtractorFactory javadoc
9830146 
Issue:#2748

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174854541
ojw28 pushed a commit that referenced this issue Nov 13, 2017
@AquilesCanta @ojw28
Fix DefaultHlsExtractorFactory javadoc
5222494 
Issue:#2748

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174854541
@google google locked and limited conversation to collaborators Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AquilesCanta AquilesCanta

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@IanDBird @stari4ek @ojw28 @AquilesCanta