-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webvtt subtitles in HLS are not displayed when the PTS wraps around #2928
Comments
The subtitles are displayed if we call adjustTsTimestamp instead of adjustTsTimestamp instead of adjustSampleTimestamp in WebvttExtractor.java, ie: long sampleTimeUs = firstCueTimeUs + timestampAdjuster.adjustTsTimestamp(Long.parseLong(mediaTimestampMatcher.group(1))) - vttTimestampUs; |
A fix will be available in the next push. Thanks for reporting and your patience! |
Issue:#2928 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169246424
This is fixed in |
Issue:#2928 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169246424
Thanks. |
Issue:#2928 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169246424
Issue description
Play a HLS stream where the PTS from the main video segment are wrapping around with webvtt subtitles.
bugreport.1.txt.gz
The webvtt subtitles are never displayed.
Reproduction steps
It is reproduced with the demo on the latest release 2.4.1.
it is not necessary, but it is easier if subtitles are set by default:
Link to test content
stream to be sent by email
Version of ExoPlayer being used
release 2.4.1 (commit 9f81485)
Device(s) and version(s) of Android being used
reproduced on Sony xperia z3 compact, as well as android tv devices.
The text was updated successfully, but these errors were encountered: