Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting thumb Drawable in DefaultTimeBar #3337

Closed
nimdokai opened this issue Oct 10, 2017 · 5 comments
Closed

Support setting thumb Drawable in DefaultTimeBar #3337

nimdokai opened this issue Oct 10, 2017 · 5 comments

Comments

@nimdokai
Copy link

As I understand from releas note of version 2.4.0 Exoplayer SeekBar was replaced by DefaultTimeBar. https://github.com/google/ExoPlayer/blob/dev-v2/RELEASENOTES.md

As I can seen, as on 19Feb2017: https://github.com/bigexxx/ExoPlayer/blob/c5db6f39a6e07b4f98364ff40476e4e213172488/library/src/main/java/com/google/android/exoplayer2/ui/PlaybackControlView.java
exo_progress was SeekBar type:
(line 285): progressBar = (SeekBar) findViewById(R.id.exo_progress);

And right now: https://github.com/google/ExoPlayer/blob/release-v2/library/ui/src/main/java/com/google/android/exoplayer2/ui/PlaybackControlView.java
it is:
(line: 384):timeBar = (TimeBar) findViewById(R.id.exo_progress);

DefaultTimeBar does not have method like .setThumb() and it seems to me that thumb is created as Canvas in private method drawPlayhead(Canvas canvas).

Question: is is possible to set own thumb icon in DefaultTimeBar?

@andrewlewis andrewlewis changed the title [Question]changing default thumb in DefaultTimeBar Support setting thumb Drawable in DefaultTimeBar Oct 10, 2017
@andrewlewis
Copy link
Collaborator

We should be able to add a way set the scrubber/thumb drawable soon. As an alternative, you could try making a wrapper around the platform SeekBar widget which implements ExoPlayer's TimeBar interface.

Do you also need a way to override the seek bar track drawable, or is it just the thumb you need to customize? Thanks.

@nimdokai
Copy link
Author

Hi Andrew,

Thank you for respond and suggestion.

Do you also need a way to override the seek bar track drawable, or is it just the thumb you need to customize?
I just need to customize thumb.

Best regards,
Wojciech

@micer
Copy link

micer commented Oct 26, 2017

Hey guys, is there any ETA when customization of the thumb Drawable will be added? I might need that one too. Btw I agree that changing seek bar drawable is not needed. Thanks!

@andrewlewis
Copy link
Collaborator

It will be pushed next time we update the development branch, which is likely to be within the next week or so.

ojw28 pushed a commit that referenced this issue Oct 27, 2017
Issue: #3337

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=173411321
@ojw28 ojw28 closed this as completed Nov 1, 2017
@ojw28
Copy link
Contributor

ojw28 commented Nov 1, 2017

This has been pushed to dev-v2.

@google google locked and limited conversation to collaborators Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants