Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on 'Lean More' Click - ImaAdsLoader #3430

Closed
alonaviram opened this issue Nov 6, 2017 · 0 comments
Closed

Crash on 'Lean More' Click - ImaAdsLoader #3430

alonaviram opened this issue Nov 6, 2017 · 0 comments
Assignees
Labels

Comments

@alonaviram
Copy link

I don't have an exact scenario, and it's pretty rare, couldn't reproduce on the demo app.
It's not specific for an ad tag or url.
I guess it's more relevant to old devices - happened to me on - LG G3 4.42
The Exception occurs probably on first install of the app and when the ad is loaded press the 'Learn More' button couple times fast.

this is the stack trace :

E/AndroidRuntime: FATAL EXCEPTION: main
        Process: com.my.app, PID: 5261
        java.lang.IllegalStateException
        at com.google.android.exoplayer2.util.Assertions.checkState(Assertions.java:79)
        at com.google.android.exoplayer2.ext.ima.ImaAdsLoader.updateImaStateForPlayerState(ImaAdsLoader.java:659)
        at com.google.android.exoplayer2.ext.ima.ImaAdsLoader.onPositionDiscontinuity(ImaAdsLoader.java:620)
        at com.google.android.exoplayer2.ExoPlayerImpl.handleEvent(ExoPlayerImpl.java:457)
        at com.google.android.exoplayer2.ExoPlayerImpl$1.handleMessage(ExoPlayerImpl.java:103)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:136)
        at android.app.ActivityThread.main(ActivityThread.java:5118)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:515)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606)
        at dalvik.system.NativeStart.main(Native Method)
@ojw28 ojw28 added the bug label Nov 6, 2017
ojw28 pushed a commit that referenced this issue Nov 21, 2017
Remove an assertion that there was a call to pause content between two
content -> ad transitions.

Also, only use the player position for resuming an ad on reattaching if the
player is currently playing an ad, in case IMA pauses content before the player
actually transitions to an ad.

Issue: #3430

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=176365842
@ojw28 ojw28 closed this as completed Nov 21, 2017
ojw28 pushed a commit that referenced this issue Nov 21, 2017
Remove an assertion that there was a call to pause content between two
content -> ad transitions.

Also, only use the player position for resuming an ad on reattaching if the
player is currently playing an ad, in case IMA pauses content before the player
actually transitions to an ad.

Issue: #3430

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=176365842
@google google locked and limited conversation to collaborators Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants