-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video with HD audio (e.g. TrueHD) stuck buffering after seek #3845
Comments
Please could you provide a clip from the test content (enough so that we can reproduce the issue in the demo app)? Thanks. |
Link emailed. Thanks! |
Hi. Were you able to reproduce the problem with my link? |
I have discovered this problem may not be limited to HD audio as I have now seen other items get stuck in this condition. |
Hi. This issue is still labeled as "Need more info" but I did provide content that easily reproduces the problem. Are you still waiting for more info? Thanks. |
Haven't got round to looking at this yet, I'm afraid. You mentioned that this is not limited to HD audio. Could you provide some sample media for that too? |
I can't provide any other media that will definitely reproduce the issue like the one I did. For other media, it is much less likely and hard to predict but I have seen it occur. It is very predictable with the media I provided though. Only one or two skips and it is going to get stuck. Thanks. |
In MatroskaExtractor TrueHD audio samples are joined into larger chunks. For some streams the resulting chunked samples seem never to start with a syncframe. This could result in playback of TrueHD streams getting stuck after seeking because we could never read a syncframe at the start of a sample to determine the sample size. Instead of expecting to find a syncframe at the start of a sample, search for it within the sample, to fix this issue. Note: this means that we may search a few thousand bytes to find the sample size, but the cost is only incurred for the first audio sample read. Issue: #3845 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=191775779
This should be fixed on |
Yes! Appears fixed. Thanks very much. |
Issue description
The player will get stuck in the "Buffering" state after SimpleExoPlayer.seekTo(). This appears to be somehow related to the HD audio as switching the very same video item to a normal (AC3) audio track will no longer reproduce the problem.
The problem isn't 100% consistent but a few seeks will almost always "stick" the player and it will sometimes "unstick" if you seek several more times.
Reproduction steps
Play content with a TrueHD audio track such that it plays directly via the MatroskaExtractor and issue a few seekTo() commands. The player will enter the buffering state and never get to ready again even though the frame on-screen updates to the proper frame.
Link to test content
Samples are extremely large. Can try to provide upon request
Version of ExoPlayer being used
2.6.1 Dev-v2 branch (as of 2/13/18).
Device(s) and version(s) of Android being used
Reproduced on NVidia Shield TV Android 7.0 Shield experience 6.3.
A full bug report captured from the device
Can attempt to produce upon request.
The text was updated successfully, but these errors were encountered: