ImaAdsLoader doesn't work with HLS content that uses EXT-X-PROGRAM-DATE-TIME #3865
Comments
|
The content media source has a window that is offset from zero, while the ad group times start from zero. This is not handled correctly in We have a fix in review which will treat ad group times as relative to the window in |
ojw28
changed the title
|
I think the new plan is to adjust |
|
@andrewlewis @ojw28 sounds good, let me know when you have a fix on HlsMediaSource to test it. Thank you! |
Before this change, HlsMediaSource timelines had a period starting at the epoch. For VOD streams the window position in the period was the program date time. This change makes period and initial window positions match. For live streams the window position advances as segments are removed, so its position in the period is the difference between the initial program date time and the program date time of the latest playlist. This also makes it possible to insert ads in VOD HLS content with program date time, as the period and window are now aligned. Issue: #3865 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=187590948
|
@priscila225 This should be fixed on the development branch. Please try it out and let us know if there are any further issues. |
|
@andrewlewis this is working fine for us. Thank you a lot! I confirmed using the sample with m3u8 links as well. Also the plan to have it on release, you have a date? Just to know if we will wait too much to have the fix on final release. Thank you! |
|
The fix will land in 2.7.1 which will likely be released this week or early next week. |
Before this change, HlsMediaSource timelines had a period starting at the epoch. For VOD streams the window position in the period was the program date time. This change makes period and initial window positions match. For live streams the window position advances as segments are removed, so its position in the period is the difference between the initial program date time and the program date time of the latest playlist. This also makes it possible to insert ads in VOD HLS content with program date time, as the period and window are now aligned. Issue: #3865 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=187590948
I'm running the demo app for v2.6.1 and I hardcoded it to play this HLS video: https://content.uplynk.com/babd2bd748ee47c48e0fb6b492245eb9.m3u8
I'm trying to use this google sample vmap: "VMAP - Pre-roll Single Ad, Mid-roll Standard Pod with 3 ads, Post-roll Single Ad"
When the playback starts I see that the prerolls doesn't play, instead I get the 3 midrolls where the preroll should be. Also I can't see the post-roll ad working, it just keeps loading forever.
The text was updated successfully, but these errors were encountered: