-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Duration for DASH is based on the shortest duration which in this case is the caption track #4029
Comments
@kqyang ^ Including you on this, as from our discussions you were suggesting that padding out the captions track to be the same duration as the audio/video tracks may be out of spec in DASH? |
@zshenker Yes, ExoPlayer's requirement is not DASH compliant. I wish this issue could be addressed in ExoPlayer. In the mean time, we'll look into handling it in Shaka Packager: shaka-project/shaka-packager#356. |
I've filed Dash-Industry-Forum/DASH-IF-IOP#178 to request clarification on whether short representations are permitted. I haven't yet found part of the DASH spec or DASH IF recommendations that say either way whether they're allowed or not. Either I've missed the relevant section, in which case please direct me to it, or this feels like an omission. If the latter, I don't think it's fair to assume it's permitted just because the spec doesn't explicitly forbid it. If we adopted that approach in general then implementing a DASH client would be fairly unworkable. I've also posted some reasons on the clarification request why I think padding such representations to have the same duration of the period would be a good idea. |
@zshenker - Padding out the captions track with empty segments is definitely not "out of spec". It's definitely allowed. The clarification I've asked for is about whether not doing this is also allowed. |
Discussed this with @joeyparrish. It looks like the DASH-IF discussion is headed in the direction of recommending padding segments to avoid short representations. However, given the time that will be required to update packagers, and that there's existing content with short representations, will will endeavor to support this case in ExoPlayer assuming a relatively low cost and side-effect free change can be made to do so. |
Issue: #4029 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202912333
Issue: #4029 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202912333
Issue description
DASH duration reported to be the shortest representation, which in the Shaka Packaged content happens to be the text track.
Reproduction steps
Exoplayer reports 2650 as the content duration. So the content playback stops at 2650 secs.
Link to test content
Emailed the license key url to "dev.exoplayer@gmail.com"
Version of ExoPlayer being used
Tested with Exo 2.5.4 and also 2.6.1
Device(s) and version(s) of Android being used
Any Android device
The text was updated successfully, but these errors were encountered: