-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipping of HLS streams from non-keyframe position starts with audio only #4241
Comments
Thanks for filing the issue. Could you please provide us with an ad tag to reproduce the issue? You can also send the link to dev.exoplayer@gmail.com if you don't want to post it publicly. |
I uploaded the original xml file. https://github.com/na-in-lee/sample
|
Seeking behind the ad + skipping works fine for me in our latest version with the described VMAP setup. |
Thanks for the answer.
|
I was able to reproduce your problem now. It's actually unrelated to ads loading and was caused by starting to play the HLS stream from a non-keyframe position. We are going to provide a fix soon. |
Currently, the sample queues are lazily enabled when they are first read from. This causes problems when the player tries to discard buffer and the HlsSampleStreamWrapper assumes the sample queue is disabled even though it's actually enabled but hasn't been read from. This change moves setting the sample queue index of the sample stream back into HlsSampleStreamWrapper. It enables the sample queues at track selection if the queues are already built, or immediately after they have been built for chunkless preparation. Issue:#4241 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=197415741
Thanks. I confirmed and applied your commit. (7b855e4) update version : 2.6.1 -> 2.8.1-rc Close the issue. |
Issue description
If i seekto() and midroll ad skip, the audio and video syncs are not right in ExoPlayer2.6.1.
It is okay if i do not video seekto() or skip the midroll ad.
if i video seekto() and skip the midroll ad, the video is frozen while the audio is playing for 3 seconds.
Reproduction steps
Test: play start > show preroll > skip preroll > play video(2sec) > move timebar(seekto(00:12:00)) > show midroll 1 > skip ad (midroll 1)
=> result : just audio play and freezing video about 2~3sec
=> If i did't seekto() and skip ad(midroll 1), it's OK.
=> if i seekto() and didn't skip ad (midroll 1), it's OK.
Video total time : 60 min
Preroll : 00:00:00
Midroll 1 position : 00:10:00
Midroll 2 position : 00:20:00
Midroll 3 position : 00:30:00
in exoplayer 2.6.1 demo
: vast count 4
: each mp4 file total 25sec, skippable 3sec
Link to test content
Provide a link to media that reproduces the issue. If you don't wish to post it
publicly, please submit the issue, then email the link to
dev.exoplayer@gmail.com using a subject in the format "Issue #1234".
Version of ExoPlayer being used
exoplayer 2.6.1
build config : demo
Device(s) and version(s) of Android being used
device name : Galaxy S8
android version: 8.1
The text was updated successfully, but these errors were encountered: