Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple post roll Ads not played properly using Exoplayer v 2.8.4 & IMA SDK v3.9.4 #4710

Closed
psiddaraj opened this issue Aug 22, 2018 · 3 comments
Closed

Multiple post roll Ads not played properly using Exoplayer v 2.8.4 & IMA SDK v3.9.4 #4710

psiddaraj opened this issue Aug 22, 2018 · 3 comments
Assignees
@andrewlewis
Labels
bug

Comments

@psiddaraj
Copy link

psiddaraj commented Aug 22, 2018 •
edited
Loading

We are testing multiple pre, mid & post roll Ads using Exoplayer 2.8.4 & IMA SDK v 3.9.4

Reproduction Steps:

  1. Load the Exoplayer with VMAP configuration with multiple ore, post & mid roll Ads using an Ad Tag URI
  2. Exoplayer plays pre & mid roll Ads without any issues.
  3. Exoplayer UI is stuck after first post-roll Ad is played & doesn't switch to the next post roll Ad.

This issue is always reproducible.
VMAP & Video of the logs are sent to Exoplayer team via mail.
@andrewlewis andrewlewis self-assigned this Aug 22, 2018
ojw28 pushed a commit that referenced this issue Aug 24, 2018
@andrewlewis @ojw28
Fix playback of postrolls with multiple ads
9c36773 
At the point of starting to play a postroll, source info refreshes for future
postroll ads in the same ad group would cause a seek that incorrectly identified
the media period to play as the content media period. Fix the logic in
getAdGroupIndexForPositionUs to address this.

Also handle empty postroll ad breaks by resetting the expected ad group index
when we send content complete.

Issue: #4710
Issue: #4681

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=210071054
@andrewlewis
Copy link
Collaborator

@psiddaraj This should be fixed on the dev-v2 branch. Please could you try it out and let us know if you see any issues? Thanks.

@psiddaraj
Copy link
Author

psiddaraj commented Aug 27, 2018 •
edited
Loading

Thanks @andrewlewis. The issue is fixed dev-v2 branch. Could you please let me know, when this patch or fix would be available in release branch ?

@andrewlewis
Copy link
Collaborator

It will probably be in 2.9.0, but we don't have a solid ETA for that yet.

@ojw28 ojw28 closed this as completed Sep 4, 2018
@google google locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @ojw28 @psiddaraj