Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio track selection always prefers first renderer #4711

Closed
ojw28 opened this issue Aug 22, 2018 · 0 comments
Closed

Audio track selection always prefers first renderer #4711

ojw28 opened this issue Aug 22, 2018 · 0 comments
Assignees
Labels

Comments

@ojw28
Copy link
Contributor

ojw28 commented Aug 22, 2018

When there are two audio renderers (e.g. because the FFmpeg extension is being used), track groups are mapped to both of them, and the application specifies a constraint on track selection, DefaultTrackSelector will always prefer a track mapped to the first renderer, even if the constraint is better satisfied by a track in the second selection. We should instead select a track for the second audio renderer in this case.

The same argument may apply for video as well, although this might be less clear cut.

@ojw28 ojw28 added the bug label Aug 22, 2018
@ojw28 ojw28 self-assigned this Aug 22, 2018
ojw28 added a commit that referenced this issue Sep 13, 2018
If we can select a track that has a strictly higher score than a
selection already made for a renderer of the same type, we should
prefer it.

Issue: #4711

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=212835895
@ojw28 ojw28 closed this as completed Sep 14, 2018
@google google locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant