-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did something change with audio track sync from 2.8.2 to 2.8.4? #4774
Comments
We are not aware of any change which causes synchronization problems. Also depends on the type of media you are using to answer that question. Can you provide us with an example? If you don't want to post it publicly, please send it to dev.exoplayer@gmail.com with "Issue #4474" in the subject. |
Sample emailed. Thanks. |
Thanks for the sample. It seems this commit of 2.8.3 fixed #4348 but broke your sample. The reason is that in both cases the file contains edit lists which do not start from a keyframe.
Will push a fix which keeps the edit lists disabled for cases as in #4348, but keeps them if only the first edit list doesn't start with a keyframe. |
Thanks very much. |
Hi. Has this been addressed yet? |
Yes, it will be part of the next release. |
Okay, thanks. Just out of curiosity, can you point me to the commit :). |
The commit will appear in this thread when it's pushed to GitHub. |
…keyframe. Ignoring all edit lists if they don't start with a keyframe causes A/V sync issues when valid edit lists are applied at the beginning. This change allows such edit lists again but removes all samples before the first keyframe (these samples would be ignored by the renderer anyway if at the beginning OR cause visible distortions when appended to an unrelated keyframe). Issue:#4774 Issue:#4348 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212244407
We recently upgraded from 2.8.2 to 2.8.4 and now have some content where audio plays out of sync with the video. Move back to 2.8.2 and the sync issue is gone.
I can try to provide a sample if needed but wanted to check if there is some known change that we can adjust to.
Thanks.
The text was updated successfully, but these errors were encountered: