SimpleExoPlayer: Cannot disable audio focus handling after enabling it #5055
Assignees
Labels
Comments
ojw28
pushed a commit
that referenced
this issue
Nov 7, 2018
This fixes an issue where disabling audio focus handling while audio focus is held would not release audio focus. A new test was added for this situation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220316866
ojw28
pushed a commit
that referenced
this issue
Nov 7, 2018
This fixes an issue where disabling audio focus handling while audio focus is held would not release audio focus. A new test was added for this situation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220316866
|
This will be fixed in 2.9.1. |
Closed
Khang-NT
added a commit
to Khang-NT/ExoPlayer
that referenced
this issue
Nov 12, 2018
* commit 'b5beb32618ac99adc58b537031a6f7c3dd761b9a': (61 commits) Fix audio focus Fix BasePlayer.next() Make BasePlayer.get[Next/Previous]WindowIndex more useful Make TimelineQueueNavigator shuffle aware Add missing update on repeat toggle mode change Fix for google#5055 - Cannot disable audio focus after enabled. Remove executable bit from some resources Work around non-empty EoS buffers with timestamp 0 Document error case for generateAudioSessionIdV21 Tweak dev guide / readme Add support for .cmf* extension in DefaultHlsExtractorFactory Update the DefaultExtractorInput's peek buffer length on each write Double the buffer duration for AC3 Remove methods now in BasePlayer Add constructor for adding payload reader factory flags Bump version to 2.9.1 Fix extended service number calculation Add convenience methods player.next() and player.previous() Add BasePlayer to avoid code duplication for common convenience methods. Fix release notes typo ... # Conflicts: # extensions/cast/build.gradle # extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/TimelineQueueNavigator.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I think there's a problem with the way this returns without doing anything:
https://github.com/google/ExoPlayer/blob/release-v2/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioFocusManager.java#L145
It probably needs to reset some state, and abandon audio focus if it was previously held. I actually wonder whether just deleting this
if (null) { return }will result in the right thing happening? @nic0lette - Could you take a look? Thanks!The text was updated successfully, but these errors were encountered: