Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black screen appears when we seek over an AdGroup. #5507

Closed
sravan1213 opened this issue Feb 13, 2019 · 5 comments
Closed

Black screen appears when we seek over an AdGroup. #5507

sravan1213 opened this issue Feb 13, 2019 · 5 comments
Assignees
Labels

Comments

@sravan1213
Copy link
Contributor

When playing ads using AdsMediaSource and AdsLoader, if we seek over an adGroup black screen appears until the ad is loaded. This does not happen when we seek within content before adGroup, it will retain the previous frame until seek position data is available.

This issue is easily reproducible in sample app. Please look into this, also provide some info where I can look in ExoPlayer to understand what is happening.

@marcbaechinger
Copy link
Contributor

marcbaechinger commented Feb 13, 2019

Thanks for your report!

I can reproduce this behaviour with an mid roll ad tag like the sample tag added below. In case a user seeks over ad marker from a position at which the ad has not yet been loaded, the surface is immediately rendered black.

https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpremidpost&cmsid=496&vid=short_onecue&correlator=

@sravan1213
Copy link
Contributor Author

@marcbaechinger @andrewlewis is there any update on this issue. If this not in your priority list could you please guide me in helping where to look in source code to fix this.

Thanks in advance.

@ojw28 ojw28 added bug and removed enhancement labels Jul 10, 2019
@ojw28 ojw28 assigned ojw28 and unassigned andrewlewis Jun 9, 2020
@ojw28
Copy link
Contributor

ojw28 commented Jun 9, 2020

This happens because we close the shutter when seeking to an unprepared period. The same issue occurs if seeking to a different (unprepared) period within the same piece of DASH content.

I think we should suppress closing the shutter in this case, provided the old and new periods belong to the same window.

ojw28 added a commit that referenced this issue Jun 11, 2020
@ojw28
Copy link
Contributor

ojw28 commented Jun 11, 2020

Fixed by the commit referenced above.

@ojw28 ojw28 closed this as completed Jun 11, 2020
ojw28 added a commit that referenced this issue Jun 17, 2020
@ojw28
Copy link
Contributor

ojw28 commented Jun 23, 2020

This will be released in 2.11.6.

@google google locked and limited conversation to collaborators Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants