-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS: chunkless preparation breaks fmp4 content playback #5524
Labels
Comments
Thanks for reporting. I'll write back as soon as I have any updates. |
A fix will be available in 2.10.0. Unfortunately it won't make it for 2.9.6. |
andrewlewis
pushed a commit
that referenced
this issue
Feb 20, 2019
HlsSampleStream#read should return end of stream when there is no mapping for the sample stream, instead of nothing read. This allows the player to transition to ended. Issue:#5524 PiperOrigin-RevId: 234764027
andrewlewis
pushed a commit
that referenced
this issue
Feb 20, 2019
HlsSampleStream#read should return end of stream when there is no mapping for the sample stream, instead of nothing read. This allows the player to transition to ended. Issue:#5524 PiperOrigin-RevId: 234764027
Please test it on 2.9.6, and comment below if you still run into the issue. If needed, i'll reopen. Thanks again for reporting! |
Thank you, I'll run some tests and update accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue description
When trying to play fmp4 content with chunkless preparation turned on, at the end of video playback the player state never changes to ended and the playback continues with the timeline ticking on.
Reproduction steps
The bug can be reproduced in the ExoPlayer demo app.
in
PlayerActivity.java
make the following code changes under thebuildMediaSource
function:Select the fmp4 bipbop content from the HLS demo content.
The playback never ends.
Link to test content
The fragment mp4 demo test content:
Version of ExoPlayer being used
ExoPlayer - tag version 2.9.5
Device(s) and version(s) of Android being used
Device: LG G6
Android version: 7.0
The text was updated successfully, but these errors were encountered: