Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVB Subtitles not working with SDK 28 #5862

Closed
P4FK47A opened this issue May 9, 2019 · 1 comment
Closed

DVB Subtitles not working with SDK 28 #5862

P4FK47A opened this issue May 9, 2019 · 1 comment
Assignees
Labels

Comments

@P4FK47A
Copy link

P4FK47A commented May 9, 2019

Hello,

i just found out that DVB subtitles from MPEG-TS stream are not showing when using SDK 28 to compile the app. Since ExoPlayer version 2.10.0 uses AndroidX, i needed to update my app to SDK 28 and then i noticed this problem. I have tested this on Android 9 Pie on Samsung Galaxy Note 9 and on Android emulator and the results are the same.

When i use my old app version with ExoPlayer 2.9.6 and SDK 27 it works just fine.

In the logcat i can see that the subtitles are supported:
D/EventLogger: [ ] Track:0, id=57/575, mimeType=application/dvbsubs, language=bul, supported=YES

But when i select them manually from track selector, this happens:
java.lang.IllegalArgumentException: Invalid Region.Op - only INTERSECT and DIFFERENCE are allowed

I found out that the issue is in DvbParser.java at row 166:
canvas.clipRect(baseHorizontalAddress, baseVerticalAddress, clipRight, clipBottom, Region.Op.REPLACE);

I downloaded ExoPlayer demo source and same thing happens there, but when i remove Region.Op.REPLACE it seems to work, but it only shows subtitles for 2-5 seconds and then they are gone.

I am looking forward for a fix regarding this, because dvb subtitles are essential part of the streams i use for my project.

@marcbaechinger
Copy link
Contributor

Thanks for reporting. We will provide a fix for this asap.

ojw28 pushed a commit that referenced this issue May 15, 2019
Issue: #5862
PiperOrigin-RevId: 248112524
@ojw28 ojw28 closed this as completed May 15, 2019
ojw28 pushed a commit that referenced this issue May 15, 2019
Issue: #5862
PiperOrigin-RevId: 248112524
@google google locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants