Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaSession extension play() not resuming a player in READY state #6093

Closed
loki666 opened this issue Jun 26, 2019 · 3 comments
Closed

MediaSession extension play() not resuming a player in READY state #6093

loki666 opened this issue Jun 26, 2019 · 3 comments
Assignees
Labels

Comments

@loki666
Copy link
Contributor

loki666 commented Jun 26, 2019

[REQUIRED] Issue description

Using the mediasession extension, the play doesnt works if the player is in READY state.

[REQUIRED] Reproduction steps

Prepare the player, and call TransportControls.play()
nothing is happening because the MediaSessionCompat.Callback.play() does nothing when the player is in READY state.
Same goes if you pause() a playing player. Pausing the player works, but it's impossible to resume it.

[REQUIRED] Link to test content

any content will do

[REQUIRED] A full bug report captured from the device

no crash

[REQUIRED] Version of ExoPlayer being used

2.10.2

[REQUIRED] Device(s) and version(s) of Android being used

any device / emulator

@tonihei
Copy link
Collaborator

tonihei commented Jun 26, 2019

@marcbaechinger Can you take a look?

@marcbaechinger
Copy link
Contributor

Yep, that's wrong. I'll provide a fix asap.

@georgi-neykov-hub
Copy link

georgi-neykov-hub commented Jul 2, 2019

@marcbaechinger , is it possible to just match the logic in PlayerControlView#1232? Or maybe, just call controlDispatcher.dispatchSetPlayWhenReady(player, true) if the current player's state is Player.STATE_READY?

ojw28 pushed a commit that referenced this issue Jul 2, 2019
ISSUE: #6093
PiperOrigin-RevId: 255471282
@ojw28 ojw28 closed this as completed Jul 2, 2019
ojw28 pushed a commit that referenced this issue Jul 9, 2019
ISSUE: #6093
PiperOrigin-RevId: 255471282
@google google locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants