Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish testutil package via jCenter #6267

Closed
rcavaltw opened this issue Aug 6, 2019 · 4 comments
Closed

Publish testutil package via jCenter #6267

rcavaltw opened this issue Aug 6, 2019 · 4 comments
Assignees

Comments

@rcavaltw
Copy link

rcavaltw commented Aug 6, 2019

[REQUIRED] Searched documentation and issues

This question is a follow up to #3810.

[REQUIRED] Question

We are developing a lib that wraps around exoplayer. It is somewhat hard to write unit test for Player.EventListener, for example, without loading a real video, thread sleeping, etc. From #3810 I noticed there's a way to emulate portions of exoplayers's behavior and was wondering if the way to go would be for us to just copy your testutil classes or if there are plans to expose them as actual testing libs, analogous to spring-test, that provides helpers and stubs for http function.

@google-oss-bot
Copy link
Collaborator

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@tonihei
Copy link
Collaborator

tonihei commented Aug 7, 2019

I don't see anything speaking against publishing these modules as they are.

Note that we are unlikely to provide new features just for testing external usages though. If you want to get started on unit tests involving the full player, please have a look at ExoPlayerTest for example, which uses ExoPlayerTestRunner.

@ojw28 ojw28 changed the title Are there plans to publish testutil and testutils_robolectric as supporting libs? Publish testutil package via jCenter Sep 2, 2019
tonihei added a commit that referenced this issue Sep 5, 2019
This allows external users to easily write unit tests involving ExoPlayer
instances.

Issue:#6267
PiperOrigin-RevId: 266741790
@tonihei
Copy link
Collaborator

tonihei commented Sep 5, 2019

Code prepared for publication. I leave this issue open until we actually ensured it's available on jCenter

@tonihei tonihei assigned ojw28 and unassigned tonihei Sep 5, 2019
@ojw28
Copy link
Contributor

ojw28 commented Dec 11, 2019

This has been requested (for 2.11.0). It's pending approval, and will hopefully be available soon.

@ojw28 ojw28 closed this as completed Dec 12, 2019
@google google locked and limited conversation to collaborators Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants